Re: Review Request 109551: port KPtyProcess to QProcess

2013-03-19 Thread Jan Kundrát
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/#review29432 --- kpty/tests/kptyprocesstest.h

Re: [cmake-developers] CMake usage requirements in KDE Frameworks

2013-03-19 Thread Brad King
On 03/19/2013 04:02 PM, Alexander Neundorf wrote: > On Tuesday 19 March 2013, Stephen Kelly wrote: >> I don't mind renaming it, but it's a topic for the cmake list. > > So, I think the variable name CMAKE_BUILD_INTERFACE_INCLUDES is to general. > Since it is similar to the effect of CMAKE_INCLUDE_

Re: CMake usage requirements in KDE Frameworks

2013-03-19 Thread Alexander Neundorf
On Tuesday 19 March 2013, Stephen Kelly wrote: > Alexander Neundorf wrote: > >> which automatically adds > >> > >> "$ >> > >> ${CMAKE_CURRENT_SOURCE_DIR}>" > >> > >> to the INTERFACE_INCLUDE_DIRECTORIES of each target. > > > > Since cmake 2.4.0. the global cmake variable CMAKE_INCLUDE_CURRENT_

Re: Review Request 109551: port KPtyProcess to QProcess

2013-03-19 Thread Oswald Buddenhagen
> On March 18, 2013, 10:04 p.m., Oswald Buddenhagen wrote: > > kpty/tests/kptyprocesstest.cpp, line 193 > > > > > > i don't think eating the sleep is a good idea. i'm sure i added it for > > a reason (in a previo