Re: Review Request 109538: port KFileMetaDataReader to QProcess

> On March 17, 2013, 2:05 p.m., Vishesh Handa wrote: > > But why? KFileMetadataReader and the other KFileMetadataStuff should just > > be marked as deprecated. Why are we porting them? We already have better > > alternatives in the nepomuk-widgets repository. > > Martin Tobias Holmedahl Sandsm

Re: Review Request 109524: Remove some compile warnings

> On March 16, 2013, 7:22 p.m., Stephen Kelly wrote: > > tier1/itemmodels/src/kselectionproxymodel.cpp, line 2148 > > > > > > Why do you remove this? This assert checks if a pointer is not negative. Why we want

Re: Review Request 109524: Remove some compile warnings

> On March 16, 2013, 8:57 p.m., David Faure wrote: > > That's right. I'm going to fix. - Miquel --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109524/#review29336 ---

Re: Review Request 109503: Compile with current qt dev branch

On Mon, Mar 18, 2013 at 4:12 AM, David Faure wrote: > On Sunday 17 March 2013 13:51:39 Stephen Kelly wrote: >> Ben Cooksley wrote: >> > Long term we either need: >> > 1) A commitment from the Qt project to make keeping qt5.git updated a >> > high priority (block all new commits from entering any s

[websites/build-kde-org/production] /: Revert "Add support for invoking special 'SCM Correction' commands, such as git submodule updates in the case of qt5."

Git commit 3c9af38533402955048caa3d120f0c09bdc84b80 by Ben Cooksley. Committed on 17/03/2013 at 20:47. Pushed by bcooksley into branch 'production'. Revert "Add support for invoking special 'SCM Correction' commands, such as git submodule updates in the case of qt5." This reverts commit 47684f21

Re: Review Request 109538: port KFileMetaDataReader to QProcess

> On March 17, 2013, 2:05 p.m., Vishesh Handa wrote: > > But why? KFileMetadataReader and the other KFileMetadataStuff should just > > be marked as deprecated. Why are we porting them? We already have better > > alternatives in the nepomuk-widgets repository. > > Martin Tobias Holmedahl Sandsm

Re: Review Request 109549: port KRun away from KProcess

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109549/#review29391 --- kio/kio/krun.cpp

Build failed in Jenkins: kdelibs_frameworks_qt5 #517

See Changes: [martin.sandsmark] Port KFileMetaDataReader to QProcess [martin.sandsmark] port KNS3 to QProcess -- [...truncated 5114 lines...] from

Re: Review Request 109538: port KFileMetaDataReader to QProcess

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109538/#review29377 --- But why? KFileMetadataReader and the other KFileMetadataStuff s

Re: Review Request 109549: port KRun away from KProcess

> On March 17, 2013, 4:41 p.m., Rolf Eike Beer wrote: > > kio/kio/krun.cpp, line 1780 > > > > > > Whitespacing around braces is inconsistent. it's consistent with the rest of the code around it? > On March 17,

Review Request 109551: port KPtyProcess to QProcess

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/ --- Review request for KDE Frameworks, kdelibs and David Faure. Description --

Review Request 109549: port KRun away from KProcess

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109549/ --- Review request for KDE Frameworks, kdelibs and David Faure. Description --

Build failed in Jenkins: kdelibs_frameworks_qt5 #518

See Changes: [martin.sandsmark] port KEditToolbar to QProcess -- [...truncated 5164 lines...] from

Re: Review Request 109503: Compile with current qt dev branch

On Sunday 17 March 2013 13:51:39 Stephen Kelly wrote: > Ben Cooksley wrote: > > Long term we either need: > > 1) A commitment from the Qt project to make keeping qt5.git updated a > > high priority (block all new commits from entering any submodule until > > the issues in question are fixed for ins

Re: Review Request 109538: port KFileMetaDataReader to QProcess

> On March 17, 2013, 2:05 p.m., Vishesh Handa wrote: > > But why? KFileMetadataReader and the other KFileMetadataStuff should just > > be marked as deprecated. Why are we porting them? We already have better > > alternatives in the nepomuk-widgets repository. Because it was a simple user of KP

Review Request 109538: port KFileMetaDataReader to QProcess

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109538/ --- Review request for KDE Frameworks, kdelibs, David Faure, and Vishesh Handa.

Build failed in Jenkins: kdelibs_frameworks_qt5 #516

See Changes: [martin.sandsmark] Remove unused desktop file [martin.sandsmark] Don't install removed desktop file [martin.sandsmark] remove unused forward declaration of KService [martin.sandsmark] update doxygen mainpage a bit [mar

Re: Review Request 109503: Compile with current qt dev branch

Ben Cooksley wrote: > Long term we either need: > 1) A commitment from the Qt project to make keeping qt5.git updated a > high priority (block all new commits from entering any submodule until > the issues in question are fixed for instance) or > 2) We need to decide to adopt either qt5.git or indi

Re: Review Request 109531: Port the Sonnet ASpell plugin to the new style APIs

> On March 17, 2013, 11:51 a.m., David Faure wrote: > > staging/sonnet/src/core/client_p.h, line 78 > > > > > > Is this used anywhere? Funnily enough, the qobject_cast in > > loadPlugin already compiles. > > A

Re: Review Request 109531: Port the Sonnet ASpell plugin to the new style APIs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109531/ --- (Updated March 17, 2013, noon) Status -- This change has been marked

Re: Review Request 109531: Port the Sonnet ASpell plugin to the new style APIs

> On March 17, 2013, 11:51 a.m., David Faure wrote: > > staging/sonnet/src/plugins/aspell/kspell_aspellclient.cpp, line 82 > > > > > > Doesn't the .json file need to exist? > > Alternatively I think the FILE ar

Re: Review Request 109531: Port the Sonnet ASpell plugin to the new style APIs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109531/#review29362 --- Looks ok to me. Just two questions. staging/sonnet/src/core/c

Re: Review Request 109503: Compile with current qt dev branch

On Sun, Mar 17, 2013 at 10:35 PM, David Faure wrote: > On Sunday 17 March 2013 20:58:08 Ben Cooksley wrote: >> On Sun, Mar 17, 2013 at 12:59 AM, Stephen Kelly wrote: >> > Ben Cooksley wrote: >> >> I tried the command invocation: >> >> git submodule foreach 'git fetch; git reset --hard origin/dev

Re: Review Request 109503: Compile with current qt dev branch

On Sunday 17 March 2013 20:58:08 Ben Cooksley wrote: > On Sun, Mar 17, 2013 at 12:59 AM, Stephen Kelly wrote: > > Ben Cooksley wrote: > >> I tried the command invocation: > >> git submodule foreach 'git fetch; git reset --hard origin/dev || git > >> reset --hard origin/master || true' > >> > >> W

Re: Review Request 109503: Compile with current qt dev branch

On Sun, Mar 17, 2013 at 12:59 AM, Stephen Kelly wrote: > Ben Cooksley wrote: > >> I tried the command invocation: >> git submodule foreach 'git fetch; git reset --hard origin/dev || git >> reset --hard origin/master || true' >> >> Which does do the job. However, as feared Jenkins is far too clever

[websites/build-kde-org/production] /: Add support for invoking special 'SCM Correction' commands, such as git submodule updates in the case of qt5.

Git commit 47684f2138d93b7dcf4d22ceb8ef4314942f9698 by Ben Cooksley. Committed on 17/03/2013 at 08:47. Pushed by bcooksley into branch 'production'. Add support for invoking special 'SCM Correction' commands, such as git submodule updates in the case of qt5. This means that qt5 builds on build.kd