Re: Please update extra-cmake-modules, kdelibs (and plasma-frameworks)

2013-02-27 Thread Sebastian Kügler
On Thursday, February 28, 2013 00:10:01 Valentin Rusu wrote: > On Wednesday 27 February 2013 22:02:52 Alexander Neundorf wrote: > > I just pushed a change to kdelibs, which renames the libraries in tier1/ > > and tier2/ to CamelCase, e.g. we have now libKCoreAddons.so etc. > > > > Along with that e

Jenkins build became unstable: kdelibs_frameworks_qt5 #451

2013-02-27 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109019/#review28233 --- This review has been submitted with commit 4d6984b7201aef18210

Re: Please update extra-cmake-modules, kdelibs (and plasma-frameworks)

2013-02-27 Thread Valentin Rusu
On Wednesday 27 February 2013 22:02:52 Alexander Neundorf wrote: > Hi, > > I just pushed a change to kdelibs, which renames the libraries in tier1/ and > tier2/ to CamelCase, e.g. we have now libKCoreAddons.so etc. > > Along with that extra-cmake-modules has been updated and is now at 0.0.8, > th

Re: Please update extra-cmake-modules, kdelibs (and plasma-frameworks)

2013-02-27 Thread Sebastian Kügler
On Wednesday, February 27, 2013 22:02:52 Alexander Neundorf wrote: > I just pushed a change to kdelibs, which renames the libraries in tier1/ > and tier2/ to CamelCase, e.g. we have now libKCoreAddons.so etc. > > Along with that extra-cmake-modules has been updated and is now at 0.0.8, > this ve

Jenkins build is back to normal : kdelibs_frameworks_qt5 #450

2013-02-27 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #449

2013-02-27 Thread KDE CI System
See Changes: [neundorf] buildsystem: the FPIE variables don't exist anymore, so remove them [neundorf] CamelCase kplotting [neundorf] CamelCase kwindowsystem library [neundorf] CamelCase KWidgetsAddons library [neundorf] CamelCase

Please update extra-cmake-modules, kdelibs (and plasma-frameworks)

2013-02-27 Thread Alexander Neundorf
Hi, I just pushed a change to kdelibs, which renames the libraries in tier1/ and tier2/ to CamelCase, e.g. we have now libKCoreAddons.so etc. Along with that extra-cmake-modules has been updated and is now at 0.0.8, this version is required now, both by kdelibs and plasma-frameworks. I hope I

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-27 Thread Kevin Ottens
On Wednesday 27 February 2013 19:22:18 Valentin Rusu wrote: > > On Feb. 27, 2013, 7:11 p.m., Kevin Ottens wrote: > > > kdeui/actions/kaction.cpp, line 77 > > > > > ine77>> > > > > Please put the space before * and &, not a

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109019/#review28229 --- Ship it! And we got a winner! Thanks a lot for your patience,

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-27 Thread Valentin Rusu
> On Feb. 27, 2013, 7:11 p.m., Kevin Ottens wrote: > > kdeui/actions/kaction.cpp, line 77 > > > > > > Please put the space before * and &, not after. Old habits. However, watching code around this I see I'm not al

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-27 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109019/ --- (Updated Feb. 27, 2013, 7:20 p.m.) Review request for KDE Frameworks, Davi

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109019/#review28223 --- kdeui/actions/kaction.cpp

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-27 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109019/ --- (Updated Feb. 27, 2013, 7:03 p.m.) Review request for KDE Frameworks, Davi

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-27 Thread Valentin Rusu
> On Feb. 27, 2013, 7:16 a.m., Kevin Ottens wrote: > > There's been a small misunderstanding I think. You introduced a slot which > > keep emitting actionGlobalShortcutChanged for actions alright *but* you > > introduced it in the wrong class. This slot should be in KAction and the > > connect

Re: workflow for adding new classes?

2013-02-27 Thread Kevin Ottens
Hello, On Wednesday 27 February 2013 12:54:24 Aaron J. Seigo wrote: > I am hoping to move the ConfigLoader class from libplasma into the kconfig > library. It needs some API review and a name change ... but before I go into > details there I was wondering if there is a desired / defined workflow f

workflow for adding new classes?

2013-02-27 Thread Aaron J. Seigo
Hi ... I am hoping to move the ConfigLoader class from libplasma into the kconfig library. It needs some API review and a name change ... but before I go into details there I was wondering if there is a desired / defined workflow for proposing new classes for inclusion in frameworks? -- Aaron

Re: CamelCasing our libraries ?

2013-02-27 Thread Martin Sandsmark
On Tue, Feb 26, 2013 at 09:11:43PM +0100, Alexander Neundorf wrote: > How is "kjs" CamelCased ? > kjs, Kjs, KJs, KJS ? Fairly certain that the correct casing is KJS (it's what is used in the source at least). -- Martin Sandsmark ___ Kde-frameworks-deve