Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

2013-01-08 Thread Aurélien Gâteau
Le lundi 31 décembre 2012 11:43:47 David Faure a écrit : [snip] > If you want to think "bigger redesign", one could consider adding the > necessary API to KDirModel so that direct usage of KDirLister isn't > necessary anymore, i.e. encapsulating it completely. Then looking at > whether all the app

Re: Review Request: kcalendarsystem: Merge KCalendarSystemQDate into KCalendarSystemGregorian.

2013-01-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108263/#review24991 --- I am perfectly fine with a Qt5 only result, yes. Getting kcalen

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

2013-01-08 Thread David Faure
On Tuesday 08 January 2013 15:52:23 Aurélien Gâteau wrote: > Le lundi 31 décembre 2012 11:43:47 David Faure a écrit : > [snip] > > > If you want to think "bigger redesign", one could consider adding the > > necessary API to KDirModel so that direct usage of KDirLister isn't > > necessary anymore,

Re: Review Request: [PATCH 4/4] kcalendarsystem: Simplify weekday naming a lot.

2013-01-08 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107696/ --- (Updated Jan. 8, 2013, 3:40 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request: [PATCH 2/4] kcalendarsystem: Simplify the dayOfWeek() implementation.

2013-01-08 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107688/ --- (Updated Jan. 8, 2013, 3:40 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request: [PATCH 3/4] kcalendarsystem: Simplify week() and weeksInYear() implementations

2013-01-08 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107690/ --- (Updated Jan. 8, 2013, 3:40 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request: [PATCH 1/4] kcalendarsystem: Fix lengthOfWeek to 7

2013-01-08 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107687/ --- (Updated Jan. 8, 2013, 3:40 p.m.) Review request for KDE Frameworks. Cha

Re: Finalized proposal for changes to i18n in KF5

2013-01-08 Thread Chusslove Illich
>> [: Chusslove Illich :] >> I'm not opposed to some additional bureaucracy in order to make the >> framework more accessible to potential users. [...] > > [: Oswald Buddenhagen :] > [...] i'd hate it to see my thoroughly engineered code being displaced by > a (possibly even slightly inferior) comp

Re: Patch: port kDebug(*) to qDebug()

2013-01-08 Thread David Faure
On Tuesday 08 January 2013 17:54:33 Jignesh Kakadiya wrote: > Hi David, > > I have ported all kDebug calls(including area number) to //qDebug() in > kio/kio directory. Please review it. Thanks! Just one thing, I see: //qDebug()( 7044 ) That's not going to compile when uncommented. This seem

Review Request: kcalendarsystem: Merge KCalendarSystemQDate into KCalendarSystemGregorian.

2013-01-08 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108263/ --- Review request for KDE Frameworks. Description --- QDate uses a prole