Re: Review Request: Cleanup : Move all gesture facilities of KAction in KGestureMap

2013-01-04 Thread Valentin Rusu
> On Jan. 4, 2013, 7:56 a.m., Kevin Ottens wrote: > > kdeui/shortcuts/kgesturemap.h, line 44 > > > > > > I'd expect to see the action as first parameter since we're kind of > > moving from "action->setGesture(gest

Re: Review Request: Cleanup : Move all gesture facilities of KAction in KGestureMap

2013-01-04 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107973/ --- (Updated Jan. 4, 2013, 9:18 p.m.) Review request for KDE Frameworks and Ke

Re: Finalized proposal for changes to i18n in KF5

2013-01-04 Thread Oswald Buddenhagen
On Sat, Dec 22, 2012 at 10:44:22AM +0100, Chusslove Illich wrote: > I have written up the headers and Doxygen pages for the Ki18n framework as > it should finally look like, available here: > excellent work. though i was too lazy to make a real api review. ^^ of course, it would be even better if

Re: Fwd: Unittests: kcalendartest.cpp

2013-01-04 Thread Chusslove Illich
> [: Kevin Ottens :] > What's missing exactly in KLocale to make the calendar system work again? > I'd like to see that resolved sooner than later. _From the translation side it needs to be switched from i18n() to tr(), just like all other tier 1 and tier 2 frameworks were. If this change causes s

Re: Fwd: Unittests: kcalendartest.cpp

2013-01-04 Thread Kevin Ottens
On Friday 14 December 2012 15:16:35 Chusslove Illich wrote: > > [: Jon Severinsson :] > > The problem is that round tripping readDate() and formatDate() no longer > > work when Hebrew numbers are involved. I have isolated the cause down to > > the ki18n split. If I revert the split [1] then this te

Re: Review Request: Cleanup : Move all gesture facilities of KAction in KGestureMap

2013-01-04 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107973/#review24635 --- OK, we're getting there. More fine-grained API proposals this t