Re: Review Request: Fix attica dependency

2012-12-26 Thread Valentin Rusu
> On Dec. 26, 2012, 9:12 a.m., Christophe Giboudeaux wrote: > > knewstuff/knewstuff3/CMakeLists.txt, line 21 > > > > > > endif() > > > > Please read > > http://techbase.kde.org/Policies/CMake_Coding_Style

Re: Review Request: Fix attica dependency

2012-12-26 Thread Christophe Giboudeaux
> On Dec. 26, 2012, 9:12 a.m., Christophe Giboudeaux wrote: > > knewstuff/knewstuff3/CMakeLists.txt, line 21 > > > > > > endif() > > > > Please read > > http://techbase.kde.org/Policies/CMake_Coding_Style

Re: Building kde-baseapps and kde-workspace over kdelibs frameworks

2012-12-26 Thread nerdopolis
On Tuesday, December 25, 2012 10:48:43 PM David Faure wrote: > On Sunday 23 December 2012 20:41:54 nerdopolis wrote: > > Now that I have KDE Frameworks working, I am trying to build kde-baseapps > > (master) and kde-workspace (master) on top of Frameworks, > > You can't do that, at this point. >

Re: Review Request: Fix attica dependency

2012-12-26 Thread Christophe Giboudeaux
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107911/#review23985 --- knewstuff/knewstuff3/CMakeLists.txt

Re: Building kde-baseapps and kde-workspace over kdelibs frameworks

2012-12-26 Thread David Faure
On Tuesday 25 December 2012 23:45:48 nerdopolis wrote: > On Tuesday, December 25, 2012 10:48:43 PM David Faure wrote: > > On Sunday 23 December 2012 20:41:54 nerdopolis wrote: > > > Now that I have KDE Frameworks working, I am trying to build > > > kde-baseapps > > > (master) and kde-workspace (mas

Re: Review Request: Fix attica dependency

2012-12-26 Thread Valentin Rusu
> On Dec. 26, 2012, 9:12 a.m., Christophe Giboudeaux wrote: > > knewstuff/knewstuff3/CMakeLists.txt, line 21 > > > > > > endif() > > > > Please read > > http://techbase.kde.org/Policies/CMake_Coding_Style

Re: Review Request: Fix attica dependency

2012-12-26 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107911/ --- (Updated Dec. 26, 2012, 10:28 a.m.) Review request for KDE Frameworks and