Review Request: [PATCH 4/4] kcalendarsystem: Simplify weekday naming a lot.

2012-12-12 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107696/ --- Review request for KDE Frameworks. Description --- Weekday names depe

Review Request: [PATCH 3/4] kcalendarsystem: Simplify week() and weeksInYear() implementations

2012-12-12 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107690/ --- Review request for KDE Frameworks. Description --- These only depend

Review Request: [PATCH 2/4] kcalendarsystem: Simplify the dayOfWeek() implementation.

2012-12-12 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107688/ --- Review request for KDE Frameworks. Description --- Day of week is the

Review Request: [PATCH 1/4] kcalendarsystem: Fix lengthOfWeek to 7

2012-12-12 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107687/ --- Review request for KDE Frameworks. Description --- Week length depend

Re: add_library NO_PREFIX

2012-12-12 Thread Alexander Neundorf
On Wednesday 12 December 2012, Kevin Ottens wrote: > On Wednesday 12 December 2012 21:27:28 Alexander Neundorf wrote: > > On Monday 10 December 2012, Kevin Ottens wrote: > > > On Monday 03 December 2012 21:57:05 Kevin Ottens wrote: > > > > On Thursday 29 November 2012 09:08:05 Alexander Neundorf wr

Re: Review Request: QtWebkit is now split in QtWebKit and QtWebKitWidgets

2012-12-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107438/#review23373 --- This review has been submitted with commit f0680b75e32645b4e06

Re: add_library NO_PREFIX

2012-12-12 Thread Kevin Ottens
On Wednesday 12 December 2012 21:27:28 Alexander Neundorf wrote: > On Monday 10 December 2012, Kevin Ottens wrote: > > On Monday 03 December 2012 21:57:05 Kevin Ottens wrote: > > > On Thursday 29 November 2012 09:08:05 Alexander Neundorf wrote: > > > > [...] > > > > So at least it seems to be quite

Re: add_library NO_PREFIX

2012-12-12 Thread Alexander Neundorf
On Monday 10 December 2012, Kevin Ottens wrote: > On Monday 03 December 2012 21:57:05 Kevin Ottens wrote: > > On Thursday 29 November 2012 09:08:05 Alexander Neundorf wrote: > > > [...] > > > So at least it seems to be quite common to have no prefix for plugins. > > > > OK, thanks for checking. I'

Re: Review Request: QtWebkit is now split in QtWebKit and QtWebKitWidgets

2012-12-12 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107438/#review23361 --- Ship it! Ship It! - Stephen Kelly On Dec. 12, 2012, 3:31 p.

Re: Review Request: QtWebkit is now split in QtWebKit and QtWebKitWidgets

2012-12-12 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107438/ --- (Updated Dec. 12, 2012, 3:31 p.m.) Review request for Build System and KDE