Re: Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

2012-11-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106970/#review22580 --- This review has been submitted with commit 7500c995162ac56dd62

Re: KLocale plans

2012-11-26 Thread David Faure
On Sunday 25 November 2012 13:49:48 Chusslove Illich wrote: > > [: David Faure :] > > I think this should be QLibrary("kf5/ktranscript"), and ensuring the file > > on disk is called ktranscript.so (no "lib" in front). > > I forgot to say I tried that too :) OK I'm having the same problem with a p

Unittests: kcalendartest.cpp

2012-11-26 Thread David Faure
One failure with Qt4: FAIL! : KCalendarTest::testHebrewStrings() Compared values are not the same Actual (calendar->readDate(calendar->formatDate(testDate, KLocale::LongDate), KLocale::NormalFormat)): Invalid QDate Expected (testDate): 2004/09/16 Loc: [/d/kde/src/5/kdelibs-frameworks/kd

Re: Using qplatformdefs.h

2012-11-26 Thread Stephen Kelly
David Faure wrote: > KF5-with-Qt5 compilation is currently broken because we can't locate > qplatformdefs.h > > This used to come from this line: > tier1/kcoreaddons/src/CMakeLists.txt: 74: > include_directories(${QT_MKSPECS_DIR}/default) # for qplatformdefs.h That line can be removed I think.