Re: KArchive for Qt4

2012-11-22 Thread Alexander Neundorf
Hi, attached is what I have so far, and I think this is how I want it to be. Creating the Config.cmake files is IMO too project specific to be generalized. Beside that, I want developers to know about these files, to know what they are for, what they should contain. Among others, so that they are

Re: Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

2012-11-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106970/#review22394 --- Ship it! I'm not an ECM expert, but this looks good to me. I'd

Re: [PATCH 1/3] Drop KDE_NO_PHONON, Phonon works on Qt5 now.

2012-11-22 Thread Jon Severinsson
Hi David This work is currently blocked due to lack of feedback on review 106970 [1]. I'll also have to rework review 106987 [2] to use PHONON_FOUND as per Steves suggestion [3]. I've now not worked on this yet because I'm busy playing with my new Raspberry Pi ;-). Best regards Jon 1: https://gi