Re: my own kdatetime patches: toString with InvalidOffset; operator==

On Saturday 27 October 2012 17:56:21 Jon Severinsson wrote: > lördagen den 27 oktober 2012 12:04:31 skrev du: > > On Friday 26 October 2012 21:38:14 Jon Severinsson wrote: > > > +QVERIFY(dateTimeInvalidTz.isValid()); > > > > It's still valid? I'm confused :-) > > I attached the wrong f*ing fi

Re: Review Request: When building Phonon five against Qt5, use qmake to detect Qt installation paths.

On Wednesday 31 October 2012 21:57:55 Stephen Kelly wrote: > David Faure wrote: > > CMakeLists.txt > > > > > > Steve? Something for you to add to the Qt5 cmake files? > > I don't know. Should phonon really install phonon plugins into the pat

Re: Review Request: Rework MediaSource(const QString &filename) constructor in phonon five.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106974/#review21340 --- Ship it! Looks good to me now. Extra nitpicking would be "get