Re: Review Request: Fix ObjectDescriptionModel<*>::staticMetaObject initialization on Qt5.

2012-11-01 Thread Jon Severinsson
onsdagen den 31 oktober 2012 22:03:08 skrev Stephen Kelly: > My strategy so far has been 'Don't bother doing the Qt 5 porting (to > kdesupport). Let the maintainers decide when they care about Qt 5'. > > It's really just more for the same people (that is, the people working on > KDE Frameworks) t

Re: Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

2012-11-01 Thread Jon Severinsson
> On Oct. 31, 2012, 4:58 p.m., David Faure wrote: > > The circular dependency (due to libinqt5 being in kdelibs currently) will > > make building a bit harder though. Shouldn't ECM be fixed NOT to require > > libinqt5? > > Jon Severinsson wrote: > There is no circular dependency, as libinq

Re: Review Request: Rework MediaSource(const QString &filename) constructor in phonon five.

2012-11-01 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106974/ --- (Updated Nov. 1, 2012, 1:48 p.m.) Review request for KDE Frameworks and Ph