Re: Review Request: Fix ObjectDescriptionModel<*>::staticMetaObject initialization on Qt5.

2012-10-31 Thread Stephen Kelly
David Faure wrote: > I can't really review this code (without much research), but I completely > support this "let's not let the fixes die for lack of review" strategy. > My strategy so far has been 'Don't bother doing the Qt 5 porting (to kdesupport). Let the maintainers decide when they care

Re: Review Request: When building Phonon five against Qt5, use qmake to detect Qt installation paths.

2012-10-31 Thread Stephen Kelly
David Faure wrote: > CMakeLists.txt > > > Steve? Something for you to add to the Qt5 cmake files? I don't know. Should phonon really install phonon plugins into the paths for *Qt* plugins and qml files? Is that a leftover from when phono

Re: Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

2012-10-31 Thread David Faure
> On Oct. 31, 2012, 4:58 p.m., David Faure wrote: > > The circular dependency (due to libinqt5 being in kdelibs currently) will > > make building a bit harder though. Shouldn't ECM be fixed NOT to require > > libinqt5? > > Jon Severinsson wrote: > There is no circular dependency, as libinq

Re: Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

2012-10-31 Thread Jon Severinsson
> On Oct. 31, 2012, 4:58 p.m., David Faure wrote: > > The circular dependency (due to libinqt5 being in kdelibs currently) will > > make building a bit harder though. Shouldn't ECM be fixed NOT to require > > libinqt5? There is no circular dependency, as libinqt5 does not depend on Phonon. The

Re: Review Request: Fix ObjectDescriptionModel<*>::staticMetaObject initialization on Qt5.

2012-10-31 Thread David Faure
> On Oct. 31, 2012, 4:16 p.m., Jon Severinsson wrote: > > Over a week and still no comments. If no one objects in the next few days, > > I'm simply gonna push this without any "Ship It!". I can't really review this code (without much research), but I completely support this "let's not let the

Re: Review Request: When building Phonon five against Qt5, use qmake to detect Qt installation paths.

2012-10-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106972/#review21252 --- CMakeLists.txt

Re: Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

2012-10-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106970/#review21251 --- The circular dependency (due to libinqt5 being in kdelibs curre

Re: Review Request: Rework MediaSource(const QString &filename) constructor in phonon five.

2012-10-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106974/#review21248 --- phonon/mediasource.cpp

Re: Review Request: Rework MediaSource(const QString &filename) constructor in phonon five.

2012-10-31 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106974/ --- (Updated Oct. 31, 2012, 4:21 p.m.) Review request for KDE Frameworks and P

Re: Review Request: Fix ObjectDescriptionModel<*>::staticMetaObject initialization on Qt5.

2012-10-31 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106976/#review21246 --- Over a week and still no comments. If no one objects in the nex

Re: Review Request: When building Phonon five against Qt5, use qmake to detect Qt installation paths.

2012-10-31 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106972/#review21245 --- Over a week and still no comments. If no one objects in the nex

Re: Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

2012-10-31 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106970/#review21244 --- Over a week and still no comments. If no one objects in the nex

Re: Review Request: Always use cmake's internal automoc support.

2012-10-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106958/#review21243 --- This review has been submitted with commit 18f042412865ce9118b

Re: Review Request: Phonon five merge and cleanup

2012-10-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106967/#review21242 --- This review has been submitted with commit 7ff1892a0b55a87ff4f

Re: Review Request: Update copy-n-paste code in FindPhononInternal.cmake with all changes in kdelibs frameworks branch

2012-10-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106971/#review21241 --- This review has been submitted with commit f4298f6da46ffe48dbc

Re: Review Request: Remove remnants of old dbus code from phonon five.

2012-10-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106969/#review21240 --- This review has been submitted with commit ccf9aebe8273335127b