Re: my own kdatetime patches: toString with InvalidOffset; operator==

2012-10-27 Thread Jon Severinsson
lördagen den 27 oktober 2012 12:04:31 skrev du: > On Friday 26 October 2012 21:38:14 Jon Severinsson wrote: > > +QVERIFY(dateTimeInvalidTz.isValid()); > > It's still valid? I'm confused :-) I attached the wrong f*ing file. Oh well, new try... From d9c886f578fd5bf4e502b67c890c949d2b817191 Mon

Re: Directory organization for frameworks with a namespace

2012-10-27 Thread Alexander Neundorf
On Thursday 25 October 2012, David Faure wrote: > Our standard directory structure for frameworks is like > staging/kwidgets/src/dialogs/kdialog.h > where "dialogs" is an arbitrary subdir name, > which works fine for such easy cases (#include ) > > But what about frameworks which want to use a nam

Re: Review Request: Fix KSystemTimeZonesPrivate::setLocalZone()

2012-10-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107038/#review21012 --- This review has been submitted with commit 61eb92ae5122294c48e

Re: KLocale plans (Re: KF5 Unit test results)

2012-10-27 Thread Chusslove Illich
> [: David Faure :] > Hi Chusslove, > > any progress? :-) No progress, but I'm going to do it right now. -- Chusslove Illich (Часлав Илић) signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-f

Re: Review Request: Fix KSystemTimeZonesPrivate::setLocalZone()

2012-10-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107038/#review20994 --- Ship it! Looks good to me. (Maybe the exported method could b

Re: my own kdatetime patches: toString with InvalidOffset; operator==

2012-10-27 Thread David Faure
On Friday 26 October 2012 21:38:14 Jon Severinsson wrote: > +QVERIFY(dateTimeInvalidTz.isValid()); It's still valid? I'm confused :-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 signature.asc Description: This is a digitally signed