Re: my own kdatetime patches: toString with InvalidOffset; operator==

2012-10-26 Thread Jon Severinsson
fredagen den 26 oktober 2012 19:23:05 skrev David Faure: > On Friday 26 October 2012 17:30:56 Jon Severinsson wrote: > > I'm no expert either, but I have picked up a few things over the last > > couple of weeks, and IMHO such a KDateTime should be invalid, but not > > null, and toString should res

Re: Review Request: Update KDateTime to use qint64 for days/secs/msecs

2012-10-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107062/#review20966 --- This review has been submitted with commit 1b2b5fc0ff358c0147d

Re: Review Request: Allow QtTest's QCOMPARE to work with mixed (u)int and q(u)int64

2012-10-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107061/#review20965 --- This review has been submitted with commit d3ec5eb4a2ed0c57d4f

Re: Review Request: Update KDateTime to use qint64 for days/secs/msecs

2012-10-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107062/#review20961 --- Ship it! Looks good. - David Faure On Oct. 26, 2012, 1:29 p

Re: my own kdatetime patches: toString with InvalidOffset; operator==

2012-10-26 Thread David Faure
On Friday 26 October 2012 17:30:56 Jon Severinsson wrote: > I'm no expert either, but I have picked up a few things over the last couple > of weeks, and IMHO such a KDateTime should be invalid, but not null, and > toString should result in a sensible, though invalid, string. Sounds sensible, but p

Re: Review Request: Allow QtTest's QCOMPARE to work with mixed (u)int and q(u)int64

2012-10-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107061/#review20960 --- Ship it! Make sure to update it if you have to make changes du

Re: my own kdatetime patches: toString with InvalidOffset; operator==

2012-10-26 Thread Jon Severinsson
torsdagen den 25 oktober 2012 23:15:21 skrev David Faure: > On Thursday 25 October 2012 22:47:00 Jon Severinsson wrote: > > Getting a valid KDateTime with a "valid but garbage" timezone spec is > > currently as simple as this: > > KTzfileTimeZoneSource source("/invalid/tzinfo/dir"); > > KDateTime

Re: Review Request: Fix KSystemTimeZonesPrivate::setLocalZone()

2012-10-26 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107038/ --- (Updated Oct. 26, 2012, 2:53 p.m.) Review request for KDE Frameworks. Ch

Build failure with Qt 5

2012-10-26 Thread Stephen Kelly
Hi, A recent patch of mine makes the frameworks branch fail to build with Qt 5: https://codereview.qt-project.org/#change,37624 I made it not possible to emit the aboutToQuit signal, which apparently KApplication tries to do. I don't know the X code that KApplication is using which tries to e

Review Request: Update KDateTime to use qint64 for days/secs/msecs

2012-10-26 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107062/ --- Review request for KDE Frameworks. Description --- Update KDateTime t

Review Request: Allow QtTest's QCOMPARE to work with mixed (u)int and q(u)int64

2012-10-26 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107061/ --- Review request for KDE Frameworks. Description --- This simplifies un

Re: Review Request: Fix KSystemTimeZonesPrivate::setLocalZone()

2012-10-26 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107038/ --- (Updated Oct. 26, 2012, 10:59 a.m.) Review request for KDE Frameworks. C

Re: Review Request: new signal void KMessageWidget::linkActivated()

2012-10-26 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107036/#review20887 --- Ship it! Looks good, thanks! - Aurélien Gâteau On Oct. 25,