Re: Review Request: Disable X11 support in plasma WindowShadows on Qt5, as the QPixmap X11 integration is gone.

2012-10-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106989/#review20740 --- This review has been submitted with commit 95fcfa81a71f4bff232

Re: Review Request: Disable X11 support in plasma WindowShadows on Qt5, as the QPixmap X11 integration is gone.

2012-10-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106989/#review20739 --- Ship it! Ship It! - David Faure On Oct. 23, 2012, 12:53 p.m

Re: Review Request: Disable X11 support in plasma WindowShadows on Qt5, as the QPixmap X11 integration is gone.

2012-10-23 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106989/ --- (Updated Oct. 23, 2012, 12:53 p.m.) Review request for KDE Frameworks. C

Re: Review Request: Disable X11 support in plasma WindowShadows on Qt5, as the QPixmap X11 integration is gone.

2012-10-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106989/#review20737 --- Ah I see. QPixmap::fromX11Pixmap, ouch. OK then, but add a #p

Re: Review Request: Disable X11 support in plasma WindowShadows on Qt5, as the QPixmap X11 integration is gone.

2012-10-23 Thread Jon Severinsson
> On Oct. 23, 2012, 10:09 a.m., David Faure wrote: > > Too hackish ;-) Please add #cmakedefine01 HAVE_X11 config-plasma.h and > > ensure it's set, like it's done in other subdirs. It already is, that is not the problem. The problem is that for this file, and this file only, the X11 specific pa

Re: Review Request: Fix KMimeTypeTest::testAllMimeTypes

2012-10-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107006/#review20735 --- This review has been submitted with commit 714849263d4ce9c9159

Re: Review Request: Disable X11 support in plasma WindowShadows on Qt5, as the QPixmap X11 integration is gone.

2012-10-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106989/#review20730 --- Too hackish ;-) Please add #cmakedefine01 HAVE_X11 config-plasm

Re: Review Request: Fix KMimeTypeTest::testAllMimeTypes

2012-10-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107006/#review20729 --- Ship it! Ship It! - David Faure On Oct. 23, 2012, 9:23 a.m.

Re: Review Request: Drop KDE_NO_PHONON hackery from KDE Frameworks

2012-10-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106987/#review20728 --- Ship it! Ship It! - David Faure On Oct. 22, 2012, 4:17 p.m.

Review Request: Fix KMimeTypeTest::testAllMimeTypes

2012-10-23 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107006/ --- Review request for KDE Frameworks. Description --- Don't use QEXPECT_