Re: Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-20 Thread Harald Sitter
> On Oct. 20, 2012, 8:23 p.m., David Faure wrote: > > kcoreaddons has KFileSystemType, to distinguish local from NFS/SMB (which I > > guess this is what this was about). > > Maybe it could go into Qt I guess for now this is ok (unless we want to > > use kcoreaddons in phonon, but I doubt th

Re: Review Request: Always use cmake's internal automoc support.

2012-10-20 Thread Ian Monroe
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106958/#review20602 --- Ship it! Ship It! - Ian Monroe On Oct. 20, 2012, 6:32 p.m.,

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106974/#review20604 --- kcoreaddons has KFileSystemType, to distinguish local from NFS/

Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-20 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106974/ --- Review request for KDE Frameworks and Phonon. Description --- QFSFile

Review Request: Update Phono five PHONON_GLOBAL_STATIC* with all changes to K_GLOBAL_STATIC* in kdelibs frameworks branch

2012-10-20 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106973/ --- Review request for KDE Frameworks and Phonon. Description --- This pa

Review Request: When building Phonon five against Qt5, use qmake to detect Qt installation paths.

2012-10-20 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106972/ --- Review request for KDE Frameworks and Phonon. Description --- This is

Review Request: Update copy-n-paste code in FindPhononInternal.cmake with all changes in kdelibs frameworks branch

2012-10-20 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106971/ --- Review request for KDE Frameworks and Phonon. Description --- This is

Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

2012-10-20 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106970/ --- Review request for KDE Frameworks and Phonon. Description --- This pa

Review Request: Remove remnants of old dbus code from phonon five.

2012-10-20 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106969/ --- Review request for KDE Frameworks and Phonon. Description --- This pa

Re: Review Request: Always use cmake's internal automoc support.

2012-10-20 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106958/ --- (Updated Oct. 20, 2012, 6:32 p.m.) Review request for KDE Frameworks and P

Review Request: Phonon five merge and cleanup

2012-10-20 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106967/ --- Review request for KDE Frameworks and Phonon. Description --- This pa