On Monday 24 September 2012 08:49:56 Pier Luigi wrote:
> I will use it of course, maintaining code already available in a larger
> codebase is not an option I would totally avoid it, although I hope it will
> go in Qt 5.1+ because otherwise I will have to make my own github repo
> with a copy of it
On Friday 12 October 2012 17:13:37 Jon Severinsson wrote:
> These tests will otherwise fail if testEra() failed last time it ran...
> ---
> kdecore/tests/kcalendartest.cpp |8
> 1 fil ändrad, 8 tillägg(+)
>
> diff --git a/kdecore/tests/kcalendartest.cpp
> b/kdecore/tests/kcalendartes
---
kdecore/date/kcalendarsystem.cpp | 42
kdecore/date/kcalendarsystem.h | 50 +---
kdecore/date/kcalendarsystemcoptic.cpp |6 ---
kdecore/date/kcalendarsystemcoptic_p.h |6 +--
kdecore/date/kcalend
---
kdecore/date/kcalendarsystem.cpp | 15 ---
kdecore/date/kcalendarsystem.h |4 ++--
kdecore/date/kcalendarsystemcoptic.cpp |4 ++--
kdecore/date/kcalendarsystemcoptic_p.h |4 ++--
kdecore/date/kcalendarsystemethiopian.cpp
Day of week is the same for a given julian day number regardless of calendar
system used.
---
kdecore/date/kcalendarsystem.cpp| 29 +++--
kdecore/date/kcalendarsystem.h |5 ++-
kdecore/date/kcalendarsystemhebrew.cpp | 10 --
kdecore/date/kcalendarsystemhe
These needs no calendar system specific code, but can work directly on the
julian day numbers.
---
kdecore/date/kcalendarsystem.cpp | 24
kdecore/date/kcalendarsystem.h | 12 +---
2 filer ändrade, 9 tillägg(+), 27 borttagningar(-)
diff --git a/kdecore/date/
This commit changes no code whatsoever, it only moves it around a bit so the
rest becomes more manageable.
---
kdecore/CMakeLists.txt |1 +
kdecore/date/kcalendarsystem.cpp | 232 --
kdecore/date/kcalendarsystem.h | 306 +--
---
kdecore/date/kdatetime.cpp | 26 +-
1 fil ändrad, 13 tillägg(+), 13 borttagningar(-)
diff --git a/kdecore/date/kdatetime.cpp b/kdecore/date/kdatetime.cpp
index dd93eca..f36a8b9 100644
--- a/kdecore/date/kdatetime.cpp
+++ b/kdecore/date/kdatetime.cpp
@@ -39,7 +39,7 @@
These need to stay in the private class, in order to provide a public version
that validates the arguments, and an internal that don't.
---
kdecore/date/kcalendarsystem.cpp |9 +++--
kdecore/date/kcalendarsystem.h | 13 +
kdecore/date/kcalendarsy
---
kdecore/date/kcalendarsystem.cpp| 118 ---
kdecore/date/kcalendarsystem.h | 51 +
kdecore/date/kcalendarsystemprivate_p.h | 18 +++--
3 filer ändrade, 54 tillägg(+), 133 borttagningar(-)
diff --git a/kdecore/date/kcalendarsystem.cp
All varians can trivially be implemented in KCalendarSystem using existing
primitives, no need for virtual.
---
kdecore/date/kcalendarsystem.cpp | 27 +++-
kdecore/date/kcalendarsystem.h |9
kdecore/date/kcalendarsystemcoptic.cpp
Week length depends on the week system (i.e. KLocale::WeekNumberSystem) used,
not the calendar used, and is 7 for all week systems supported by KDE.
---
kdecore/date/kcalendarsystem.cpp | 29 --
kdecore/date/kcalendarsystem.h | 18 +
It really don't belong in the calendar, and removing it lets us remove
some very bogous values for calendars not tied to an Abrahamitic religion.
Note that API remains as an depecated alias for KLocale::weekDayOfPray(),
which may return 0 for no cultural week day of prayer, which the existing
docu
This is locale dependent, not calendar system dependent, so no need to be
virtual.
Also remove bogous tests, would break if tests were run on a non-standard
locale.
---
kdecore/date/kcalendarsystem.cpp |5 -
kdecore/date/kcalendarsystem.h | 11 +++
kdecore/tests/kcalendartest
---
kdecore/date/kcalendarsystem.cpp |8
kdecore/date/kcalendarsystem.h |3 +--
kdecore/date/kcalendarsystemcoptic.cpp | 10 +-
kdecore/date/kcalendarsystemcoptic_p.h |1 +
kdecore/date/kcalendarsystemcopticprivat
---
kdecore/date/kcalendarsystem.cpp | 107 --
kdecore/date/kcalendarsystem.h | 99 ++-
kdecore/tests/kcalendartest.cpp | 87 ---
kdecore/tests/kdatetimetest.cpp |2 +-
kdeui/widgets/kdatep
---
kdecore/date/kcalendarsystem.cpp| 28 +++-
kdecore/date/kcalendarsystemprivate_p.h |1 -
2 filer ändrade, 7 tillägg(+), 22 borttagningar(-)
diff --git a/kdecore/date/kcalendarsystem.cpp b/kdecore/date/kcalendarsystem.cpp
index f146d99..11fd86c 100644
---
Make these virtual methods pure virtual instad.
---
kdecore/date/kcalendarsystem.cpp| 235 ---
kdecore/date/kcalendarsystem.h |6 +-
kdecore/date/kcalendarsystemprivate_p.h | 30 ++--
3 filer ändrade, 18 tillägg(+), 253 borttagningar(-)
diff --g
---
kdecore/date/kcalendarsystem.h| 19 +++
kdecore/date/kcalendarsystemgregorian_p.h |1 -
2 filer ändrade, 3 tillägg(+), 17 borttagningar(-)
diff --git a/kdecore/date/kcalendarsystem.h b/kdecore/date/kcalendarsystem.h
index ec74ae0..d4eef22 100644
--- a/kdecore
---
kdecore/date/kcalendarsystemgregorian.cpp |3 ++-
1 fil ändrad, 2 tillägg(+), 1 borttagning(-)
diff --git a/kdecore/date/kcalendarsystemgregorian.cpp
b/kdecore/date/kcalendarsystemgregorian.cpp
index 12d096a..92fd882 100644
--- a/kdecore/date/kcalendarsystemgregorian.cpp
+++ b/kdecore/da
These tests will otherwise fail if testEra() failed last time it ran...
---
kdecore/tests/kcalendartest.cpp |8
1 fil ändrad, 8 tillägg(+)
diff --git a/kdecore/tests/kcalendartest.cpp b/kdecore/tests/kcalendartest.cpp
index 9ca5ed4..397166a 100644
--- a/kdecore/tests/kcalendartest.cp
This because QDate in Qt5 uses the proleptic gregorian calendar, while Qt5
uses a gregorian / proleptic julian hybrid, and thus QDate(1, 1, 1) refers
to different dates depending on Qt version...
---
kdecore/tests/kcalendartest.cpp | 14 +++---
1 fil ändrad, 7 tillägg(+), 7 borttagningar
Hi
I have recently been working a bit on getting KCalendarSystem and friends into
shape in the rameworks branch. This fixes all but one failure in kcalendartest
on Qt5, but more importanty it cleans up the total mess that there currently
is in the calendar system. There is still a lot to do in thi
On Tuesday 09 October 2012 23:30:50 Jon Severinsson wrote:
> tisdagen den 9 oktober 2012 23:08:31 skrev David Faure:
> > On Tuesday 09 October 2012 22:36:45 Jon Severinsson wrote:
> > > And the stuff about Julian vs Proleptic Gregorian, but the paragraph you
> > > quoted should stay.
> >
> > Than
24 matches
Mail list logo