Re: Simple script to patch kdelibs frameworks CMakeLists.txt

2012-08-23 Thread Kevin Ottens
On Friday 24 August 2012 00:11:17 David Faure wrote: > On Thursday 23 August 2012 22:27:50 Kevin Ottens wrote: > > Hello, > > > > On Tuesday 14 August 2012 22:29:22 Alexander Neundorf wrote: > > > attached is a simple ruby script to update some (currently two) settings > > > in > > > the CMakeLists

Re: Simple script to patch kdelibs frameworks CMakeLists.txt

2012-08-23 Thread David Faure
On Thursday 23 August 2012 22:27:50 Kevin Ottens wrote: > Hello, > > On Tuesday 14 August 2012 22:29:22 Alexander Neundorf wrote: > > attached is a simple ruby script to update some (currently two) settings > > in > > the CMakeLists.txt of the kdelibs frameworks branch. > > > > It currently has t

Re: Review LibKdeAccessibilityClient

2012-08-23 Thread Kevin Ottens
Hello, On Thursday 16 August 2012 09:29:27 Frederik Gladhorn wrote: > Feedback is much appreciated. If you aim at releasing with KDE Frameworks, I would like to see the following happening: * Stick to the "new CMake ways" we use in KDE Frameworks (means depending on CMake 2.8.9 and ECM 0.0.5 for

Re: Simple script to patch kdelibs frameworks CMakeLists.txt

2012-08-23 Thread Kevin Ottens
Hello, On Tuesday 14 August 2012 22:29:22 Alexander Neundorf wrote: > attached is a simple ruby script to update some (currently two) settings in > the CMakeLists.txt of the kdelibs frameworks branch. > > It currently has two options: > > patchkf5cmake --ecm-version 0.0.5 : set the required e-c-m

Re: Definition of done - warning

2012-08-23 Thread Kevin Ottens
On Tuesday 07 August 2012 19:37:59 Albert Astals Cid wrote: > El Dimarts, 7 d'agost de 2012, a les 16:56:01, Kevin Ottens va escriure: > > I remember David and Laurent pushing the bar quite a bit regarding the > > warnings but then they gave up because people kept not caring enough about > > those.

Re: [kdelibs/frameworks] /: Use #if HAVE_X11 instead of #ifdef HAVE_X11 as advised by David

2012-08-23 Thread Kevin Ottens
On Friday 10 August 2012 20:57:57 David Faure wrote: > On Friday 03 August 2012 13:08:34 Kevin Ottens wrote: > > Use #if HAVE_X11 instead of #ifdef HAVE_X11 as advised by David > > And the goal of detecting missing #includes... worked :-) > > plasma/private/windowshadows.cpp:128:5: warning: "HAVE_X