Re: Review Request: Remove uses of KApplication where not needed

2012-08-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106063/#review17674 --- Ship it! Ship It! - David Faure On Aug. 18, 2012, 3:23 p.m.

Re: Review Request: Remove uses of KApplication where not needed

2012-08-18 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106063/ --- (Updated Aug. 18, 2012, 3:23 p.m.) Review request for KDE Frameworks. De

Re: Review Request: Remove uses of KApplication where not needed

2012-08-18 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106063/ --- (Updated Aug. 18, 2012, 3:23 p.m.) Review request for KDE Frameworks. Ch

Re: KColorScheme

2012-08-18 Thread David Faure
On Thursday 09 August 2012 17:16:27 Matthew Woehlke wrote: > I think you're going to have to either: > a. Accept a SIC and just let some roles be wrong for old code > b. Have a suffix on all the new flags > c. Put the new flags in some namespace that isn't QPalette, and keep a > method taking the

Re: Review Request: Remove uses of KApplication where not needed

2012-08-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106063/#review17640 --- kdeui/tests/klineedittest.cpp