Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests. Remove KAboutData where no longer needed.

> On Aug. 10, 2012, 8:23 a.m., David Faure wrote: > > > > Jeremy Paul Whiting wrote: > How do I run just one test? just execute the .shell file? If so I get > the following: > > [jeremy@sonic tests]$ ./kmainwindow_unittest.shell > > /home/jeremy/devel/kde/src/kf5/kdelibs/bu

Re: Definition of done - warning

On Tuesday 07 August 2012 19:37:59 Albert Astals Cid wrote: > El Dimarts, 7 d'agost de 2012, a les 16:56:01, Kevin Ottens va escriure: > > Hello, > > > > Looks like it got overlooked. ;-) > > > > On Saturday 07 July 2012 12:20:01 Benjamin Port wrote: > > > Currently when we build kdelibs there ar

Re: KF5 Unit test results

New baseline for Qt4-based builds: All tests pass, except for the 3 plasma ones, for lack of any interested plasma hacker. If you see any different result, check your setup, check why individual tests fail, and if you still can't figure it out, post test output here. -- David Faure, fa...@kde

Re: [kdelibs/frameworks] /: Use #if HAVE_X11 instead of #ifdef HAVE_X11 as advised by David

On Friday 03 August 2012 13:08:34 Kevin Ottens wrote: > Use #if HAVE_X11 instead of #ifdef HAVE_X11 as advised by David And the goal of detecting missing #includes... worked :-) plasma/private/windowshadows.cpp:128:5: warning: "HAVE_X11" is not defined [-Wundef] -- David Faure, fa...@kde.org,

Re: KF5 Unit test results

On Friday 10 August 2012 14:19:17 Chusslove Illich wrote: > > [: David Faure :] > > 5 - kdecore-klocalizedstringtest (Failed) // I don't get it. > > dgettext("kdelibs4", msgid) works in kdelibs-4.9 and not here > I've fixed this now. Thanks Chusslove, you rock! -- David Faure, fa...@kde.org,

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests. Remove KAboutData where no longer needed.

On Friday 10 August 2012 14:52:01 Jeremy Paul Whiting wrote: > > On Aug. 10, 2012, 8:23 a.m., David Faure wrote: > How do I run just one test? just execute the .shell file? If so I get the > following: > > [jeremy@sonic tests]$ ./kmainwindow_unittest.shell > /home/jeremy/devel/kde/src/kf5/kdelib

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests. Remove KAboutData where no longer needed.

> On Aug. 10, 2012, 8:23 a.m., David Faure wrote: > > How do I run just one test? just execute the .shell file? If so I get the following: [jeremy@sonic tests]$ ./kmainwindow_unittest.shell /home/jeremy/devel/kde/src/kf5/kdelibs/build/kdeui/tests/kmainwindow_unittest: symbol lookup error:

Re: KF5 Unit test results

> [: Chusslove Illich :] > translateQt fails (for me?), I didn't touch anything about that. False alarm, forgot to install kdeqt.po. -- Chusslove Illich (Часлав Илић) signature.asc Description: This is a digitally signed message part. ___ Kde-framewo

Re: KF5 Unit test results

> [: David Faure :] > 5 - kdecore-klocalizedstringtest (Failed) // I don't get it. > dgettext("kdelibs4", msgid) works in kdelibs-4.9 and not here I've fixed this now. translateQt fails (for me?), I didn't touch anything about that. -- Chusslove Illich (Часлав Илић) signature.asc Descrip

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests. Remove KAboutData where no longer needed.

On Friday 10 August 2012 08:23:29 David Faure wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105955/#review17178 > --- > >

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests. Remove KAboutData where no longer needed.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105955/#review17178 --- - David Faure On Aug. 10, 2012, 3 a.m., Jeremy Paul Whiting w