Re: Review Request: Make kcodecs framework build standalone

2012-08-08 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105860/#review17131 --- +1 (in qt-project terms) - Oswald Buddenhagen On Aug. 8, 201

Re: Review Request: Don't lose the original CMAKE_MODULE_PATH

2012-08-08 Thread Patrick Spendrin
Am 08.08.2012 22:52, schrieb Alexander Neundorf: > On Tuesday 07 August 2012, Patrick Spendrin wrote: > >> Am 07.08.2012 22:42, schrieb Alexander Neundorf: > > ... > >> > Setting CMAKE_REQUIRED_INCLUDES and CMAKE_REQUIRED_LIBRARIES within the > >> > Config.cmake file is not good style. > >> >

Re: Review Request: Don't lose the original CMAKE_MODULE_PATH

2012-08-08 Thread Alexander Neundorf
On Tuesday 07 August 2012, Patrick Spendrin wrote: > Am 07.08.2012 22:42, schrieb Alexander Neundorf: ... > > Setting CMAKE_REQUIRED_INCLUDES and CMAKE_REQUIRED_LIBRARIES within the > > Config.cmake file is not good style. > > > > Finding a package should not change the behaviour of cmake, just pr

Re: Review Request: Make kcodecs framework build standalone

2012-08-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105860/#review17112 --- Good work, just one issue. tier1/kcodecs/src/kcharsets.cpp