---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105860/#review17131
---
+1 (in qt-project terms)
- Oswald Buddenhagen
On Aug. 8, 201
Am 08.08.2012 22:52, schrieb Alexander Neundorf:
> On Tuesday 07 August 2012, Patrick Spendrin wrote:
>
>> Am 07.08.2012 22:42, schrieb Alexander Neundorf:
>
> ...
>
>> > Setting CMAKE_REQUIRED_INCLUDES and CMAKE_REQUIRED_LIBRARIES within the
>
>> > Config.cmake file is not good style.
>
>> >
On Tuesday 07 August 2012, Patrick Spendrin wrote:
> Am 07.08.2012 22:42, schrieb Alexander Neundorf:
...
> > Setting CMAKE_REQUIRED_INCLUDES and CMAKE_REQUIRED_LIBRARIES within the
> > Config.cmake file is not good style.
> >
> > Finding a package should not change the behaviour of cmake, just pr
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105860/#review17112
---
Good work, just one issue.
tier1/kcodecs/src/kcharsets.cpp