Fwd: [kdelibs/frameworks] kdecore/util: This makes K_EXPORT_PLUGIN work with Qt5 again.

2012-08-06 Thread David Faure
-- Forwarded Message -- Subject: [kdelibs/frameworks] kdecore/util: This makes K_EXPORT_PLUGIN work with Qt5 again. Date: Monday 06 August 2012, 17:59:21 From: David Faure To: kde-comm...@kde.org CC: kde-framewo...@kde.org, thi...@kde.org Git commit dfdb6762045bc47becf2d9abb2a

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.

2012-08-06 Thread David Faure
On Monday 06 August 2012 13:53:08 Jeremy Whiting wrote: > I didn't check the make test against the result you are getting on the main > branch, no. I'll remove the KAboutData from these and check that. Some of > these KAboutData have quite a bit in them, is it ok to nuke them? Don't nuke those t

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.

2012-08-06 Thread Jeremy Whiting
I didn't check the make test against the result you are getting on the main branch, no. I'll remove the KAboutData from these and check that. Some of these KAboutData have quite a bit in them, is it ok to nuke them? I also found one KApplication usage in an io slave that's part of the patch, is

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.

2012-08-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105897/#review16996 --- Thanks, a good start. BTW did you try running the tests afterw

Re: Review Request: Don't lose the original CMAKE_MODULE_PATH

2012-08-06 Thread Alexander Neundorf
On Monday 06 August 2012, Patrick Spendrin wrote: > > On Aug. 5, 2012, 9:12 a.m., David Faure wrote: > > > tier2/kconfig/CMakeLists.txt, line 7 > > > > > ne7> > > > > > > Ah, damn, there are conflicting goals here. > > >

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.

2012-08-06 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105897/ --- (Updated Aug. 6, 2012, 6:53 p.m.) Review request for KDE Frameworks and Da

Re: Reviewboard

2012-08-06 Thread Albert Astals Cid
El Dilluns, 6 d'agost de 2012, a les 12:05:00, Jeremy Whiting va escriure: > I tried adding frameworks group to the last review I posted for the > cleanup task I just finished, but rb said there's no such group... kdeframeworks Albert > > Jeremy > > On Fri, Jul 20, 2012 at 10:04 AM, David Faur

Re: Reviewboard

2012-08-06 Thread David Faure
On Monday 06 August 2012 12:05:00 Jeremy Whiting wrote: > I tried adding frameworks group to the last review I posted for the > cleanup task I just finished, but rb said there's no such group... It's "kdeframeworks". -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to w

Re: Reviewboard

2012-08-06 Thread Jeremy Whiting
I tried adding frameworks group to the last review I posted for the cleanup task I just finished, but rb said there's no such group... Jeremy On Fri, Jul 20, 2012 at 10:04 AM, David Faure wrote: > There is now a "frameworks" group on reviewboard, which you can use so that > reviews are sent to t

Re: KF5 Unit test results

2012-08-06 Thread David Faure
On Sunday 29 July 2012 14:53:47 David Faure wrote: > 71 - kdeui-kstartupinfo_unittest (Failed) // hangs. > KXMessages::x11Event needs porting to XCB Fixed. > 76 - kdeui-ktoolbar_unittest (Failed) // something about the keyboard > modifiers > in triggered(Qt::MouseButtons,Qt::Keybo

Re: Review Request: KF5 - Q_OS_* not defined

2012-08-06 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105868/ --- (Updated Aug. 5, 2012, 10:28 p.m.) Review request for KDE Frameworks and k

Review Request: Kill contextMenuKey

2012-08-06 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105884/ --- Review request for KDE Frameworks and David Faure. Description --- Ki

Re: Review Request: KF5 - Q_OS_* not defined

2012-08-06 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105868/ --- (Updated Aug. 5, 2012, 10:25 p.m.) Review request for KDE Frameworks and k

Re: Review Request: Kill contextMenuKey

2012-08-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105884/#review16964 --- Ship it! Good, but please add an entry in KDE5PORTING.html so

Re: Review Request: Make kcodecs framework build standalone

2012-08-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105860/#review16961 --- QObject::tr() sets a context of "QObject", which won't match. Y

Re: Review Request: Don't lose the original CMAKE_MODULE_PATH

2012-08-06 Thread Patrick Spendrin
> On Aug. 5, 2012, 9:12 a.m., David Faure wrote: > > tier2/kconfig/CMakeLists.txt, line 7 > > > > > > Ah, damn, there are conflicting goals here. > > > > We removed ${CMAKE_MODULE_PATH} on purpose so that eac