Re: Patch: Use kcoreauthorized.h instead of kauthorized.h.

2012-06-15 Thread David Faure
On Friday 15 June 2012 18:49:29 Jignesh Kakadiya wrote: > Use of KAuthorized for methods other than *UrlAction, should include > kcoreauthorized.h rather than kauthorized.h. > > Please review it. Assuming it compiles (of course), please commit. -- David Faure, fa...@kde.org, http://www.davidfau

Patch: Use kcoreauthorized.h instead of kauthorized.h.

2012-06-15 Thread Jignesh Kakadiya
Use of KAuthorized for methods other than *UrlAction, should include kcoreauthorized.h rather than kauthorized.h. Please review it. Thanks, Jignesh kcoreauthorized.patch Description: Binary data ___ Kde-frameworks-devel mailing list Kde-frameworks-dev

Re: Patch: Use QLatin1String instead of KGlobal::staticQString

2012-06-15 Thread Jignesh Kakadiya
Updated patch. -Jignesh On Thu, Jun 14, 2012 at 9:42 PM, Jignesh Kakadiya wrote: > Hi, > > All occurrences of KGlobal::staticQString in kdelibs are removed in favour > of direct usage of QLatin1String. > > Please review it. > > Thanks, > Jignesh > staticQString_cleanup.patch Description: Binar

Patch: Use QLatin1String instead of KGlobal::staticQString

2012-06-15 Thread Jignesh Kakadiya
Hi, All occurrences of KGlobal::staticQString in kdelibs are removed in favour of direct usage of QLatin1String. Please review it. Thanks, Jignesh staticQString_cleanup.patch Description: Binary data ___ Kde-frameworks-devel mailing list Kde-framewor

Re: Patch: Use QLatin1String instead of KGlobal::staticQString

2012-06-15 Thread David Faure
On Thursday 14 June 2012 22:13:28 Jignesh Kakadiya wrote: > Updated patch. This will call db.mimeTypeForName() every time, in the unlikely where the mimetype is missing, so my suggestion was defaultFolderIcon = "unknown"; rather than return DesktopIcon( "unknown", _size, _state ); (just under