Re: Which package will provide the common KDE library version number ?

2012-04-11 Thread Stephen Kelly
Alexander Neundorf wrote: > On Saturday 10 March 2012, Alexander Neundorf wrote: > ... >> Also, this means the term "KDE frameworks" doesn't actually mean a lot. >> I mean, what would make a library a "KDE frameworks library" ? >> Being part of the KDE SC releases ? >> >> But I'm really not sure

Re: fix frameworks-kactions compile error

2012-04-11 Thread Stephen Kelly
Giorgos Tsiapaliwkas wrote: > On 11 April 2012 19:59, Stephen Kelly wrote: >> >> That depends on what is supposed to go into kwidgets, which I wrote >> previously is not clear or decided yet. > > what should we do with this one? We should talk about what should be moved, and why, and what depen

Re: Which package will provide the common KDE library version number ?

2012-04-11 Thread Alexander Neundorf
On Saturday 10 March 2012, Alexander Neundorf wrote: ... > Also, this means the term "KDE frameworks" doesn't actually mean a lot. > I mean, what would make a library a "KDE frameworks library" ? > Being part of the KDE SC releases ? > > But I'm really not sure this will result in a pleasant exper

Re: fix frameworks-kactions compile error

2012-04-11 Thread Giorgos Tsiapaliwkas
On 11 April 2012 19:59, Stephen Kelly wrote: > > That depends on what is supposed to go into kwidgets, which I wrote > previously is not clear or decided yet. what should we do with this one? I haven't changed anything to my branch and I won't until the frameworks team decide what kwidgets shou

Re: fix frameworks-kactions compile error

2012-04-11 Thread Giorgos Tsiapaliwkas
On 11 April 2012 18:36, David Faure wrote: > > kwidgets doesn't need kactions, does it? If so, then we need to rethink > this. > Actually, KIcon* should be in kguiaddons, not in kwidgets, I think. > yes it does. We can't link them due to a circular. -- Giorgos Tsiapaliwkas (terietor) KDE Develo

Re: fix frameworks-kactions compile error

2012-04-11 Thread Stephen Kelly
David Faure wrote: > On Wednesday 11 April 2012 18:16:37 Antonis Tsiapaliokas wrote: >> Hello, >> >> I am trying to finish the frameworks-kactions branch but i cannot fix a >> compile error. >> Here is the error http://paste.kde.org/455594/ >> >> And those are the local changes that i have made

Re: fix frameworks-kactions compile error

2012-04-11 Thread David Faure
On Wednesday 11 April 2012 18:16:37 Antonis Tsiapaliokas wrote: > Hello, > > I am trying to finish the frameworks-kactions branch but i cannot fix a > compile error. > Here is the error http://paste.kde.org/455594/ > > And those are the local changes that i have made to frameworks-kactions > >

Re: libkwidgets (Re: patches on kcolors)

2012-04-11 Thread Stephen Kelly
Giorgos Tsiapaliwkas wrote: > On 11 April 2012 14:55, Stephen Kelly wrote: >> >> It's not clear which patch you're talking about. As far as I can see, you >> didn't really post the patches individually, but just posted the moevs >> that you made along with the CMakeLists changes you made (as one

Re: libkwidgets (Re: patches on kcolors)

2012-04-11 Thread Giorgos Tsiapaliwkas
On 11 April 2012 14:55, Stephen Kelly wrote: > > It's not clear which patch you're talking about. As far as I can see, you > didn't really post the patches individually, but just posted the moevs that > you made along with the CMakeLists changes you made (as one patch). > yes it is one patch beca

Re: libkwidgets (Re: patches on kcolors)

2012-04-11 Thread Stephen Kelly
Giorgos Tsiapaliwkas wrote: > On 11 April 2012 00:54, David Faure wrote: >> >> Is this a patch for 'frameworks' or for 'frameworks-kcolors'? >> > > which one? the sonnet one? All of them are for the kwidgets branch. It's not clear which patch you're talking about. As far as I can see, you did

Re: libkwidgets (Re: patches on kcolors)

2012-04-11 Thread Giorgos Tsiapaliwkas
On 11 April 2012 00:54, David Faure wrote: > > Is this a patch for 'frameworks' or for 'frameworks-kcolors'? > which one? the sonnet one? All of them are for the kwidgets branch. I can make the move in the frameworks(of course a review first), but then I will need the change. > Per Steve's las