Re: [kdelibs/frameworks-kcolors] /: Move khbox and kvbox from kdeui/widgets to staging/kwidgets/src/widgets

2012-03-11 Thread Giorgos Tsiapaliwkas
Hello, I think that it's not possible to merge my commit to frameworks. Go to frameworks-kcolors branch and look into this commit, d470e76948624257610bd7c583c442a542411093 The commit also applies a change to kcolorwidgets. In order kcolors to work I have to do a few more splitting. The kcolors

Re: Anything left to do in CMake ?

2012-03-11 Thread Alexander Neundorf
On Sunday 11 March 2012, David Faure wrote: > On Saturday 10 March 2012 16:25:57 Alexander Neundorf wrote: > > Hi, > > > > I think things are looking quite good, and we got most of the things we > > wanted to get into cmake in. > > > > Is something still left which should go into cmake ? > > Is

Re: patches on kcolors

2012-03-11 Thread Giorgos Tsiapaliwkas
On 11 March 2012 11:38, David Faure wrote: > > All into the kwidgets frameworks, but can you do that in the frameworks > branch, after merging or cherry-picking the kwidgets frameworks creation > into > it? [cf other emails] > If I am correct cherry-picking makes merging harder. So I would prefe

Re: [kdelibs/frameworks-kcolors] /: Move khbox and kvbox from kdeui/widgets to staging/kwidgets/src/widgets

2012-03-11 Thread Ben Cooksley
On Sun, Mar 11, 2012 at 10:02 PM, David Faure wrote: > On Sunday 11 March 2012 21:27:05 Ben Cooksley wrote: >> In general, we discourage force pushing on public, published branches >> due to the problems it has been known to give those with pre-existing >> checkouts of the affected branches. Given

Re: patches on kcolors

2012-03-11 Thread David Faure
On Sunday 11 March 2012 11:16:01 Giorgos Tsiapaliwkas wrote: > On 10 March 2012 12:49, David Faure wrote: > > > > > KGuiItem should move to kguiaddons I think. > > > > > Which means moving KIcon and KIconLoader/KIconTheme too (KGuiItem > > > > > depends > > > > > on it). > > So,where should I mov

Re: patches on kcolors

2012-03-11 Thread Giorgos Tsiapaliwkas
On 10 March 2012 12:49, David Faure wrote: > > > > > KGuiItem should move to kguiaddons I think. > > > > Which means moving KIcon and KIconLoader/KIconTheme too (KGuiItem > > > > depends > > > > on it). > So,where should I move KGuiItem, KIcon and KIconLoader/KIconTheme?? -- Giorgos Tsiapaliwka

Re: [kdelibs/frameworks-kcolors] /: Move khbox and kvbox from kdeui/widgets to staging/kwidgets/src/widgets

2012-03-11 Thread David Faure
On Sunday 11 March 2012 21:27:05 Ben Cooksley wrote: > In general, we discourage force pushing on public, published branches > due to the problems it has been known to give those with pre-existing > checkouts of the affected branches. Given this is a semi-private work > branch, it should be fine in

Re: [kdelibs/frameworks-kcolors] /: Move khbox and kvbox from kdeui/widgets to staging/kwidgets/src/widgets

2012-03-11 Thread Ben Cooksley
On Sun, Mar 11, 2012 at 8:33 PM, David Faure wrote: > On Wednesday 07 March 2012 15:17:13 Giorgos Tsiapaliwkas wrote: >> Git commit d470e76948624257610bd7c583c442a542411093 by Giorgos Tsiapaliwkas. >> Committed on 07/03/2012 at 15:16. >> Pushed by tsiapaliwkas into branch 'frameworks-kcolors'. >>

Re: KF5 Volunteer day 1: Done

2012-03-11 Thread David Faure
On Sunday 11 March 2012 08:29:53 David Faure wrote: > On Monday 27 February 2012 22:02:53 Kevin Ottens wrote: > >- Manual tests in: staging/kguiaddons/tests > > You mean staging/kguiaddons/examples, I think. Oh, you're right, I hadn't noticed that the directory structure policy had 3, not ju