Re: kio-stash is in KDE Review

2017-07-05 Thread Sandro Knauß
Hey, > Not too sure what is going on with that part - I also did 'gpg2 > --send-keys 2A7D2DAE'. However, it doesn't show up when I search for > it on keys.gnupg.net Well you should maybe define the keyserver, than you know where it is :) I Personally prefere the sks-keservers.net: gpg --keyserv

Re: kio-stash is in KDE Review

2017-07-04 Thread Arnav Dhamija
> Tar is signed with key 2A7D2DAE but I can't find it on the keyservers, where > was it submitted? Not too sure what is going on with that part - I also did 'gpg2 --send-keys 2A7D2DAE'. However, it doesn't show up when I search for it on keys.gnupg.net On Tue, Jul 4, 2017 at 2:31 PM, Jonathan R

Re: kio-stash is in KDE Review

2017-07-04 Thread Jonathan Riddell
On Fri, Jun 30, 2017 at 08:18:51AM +0530, Arnav Dhamija wrote: > >> Tagging 1.0 > >> gpg: Signature made Thu 29 Jun 2017 12:31:50 BST using RSA key ID DBAF2267 > >> gpg: Can't check signature: No public key Tar is signed with key 2A7D2DAE but I can't find it on the keyservers, where was it submit

Re: kio-stash is in KDE Review

2017-07-04 Thread Jonathan Riddell
Planet says you've released, well done :) Do send an announce to kde-apps-announce@ so we know about it Jonathan On Fri, Jun 30, 2017 at 08:18:51AM +0530, Arnav Dhamija wrote: > > I can't find your key on the openpgp key servers > > I've uploaded the keys. Please let me know if there still is

Re: kio-stash is in KDE Review

2017-06-30 Thread Luigi Toscano
Arnav Dhamija ha scritto: > On Thu, Jun 29, 2017 at 5:15 PM, Luigi Toscano > wrote: >> Please hold on the release. The Messages.sh was fixed only yesterday, so 1.0 >> won't have translations. It may not be an issue, but I would pay a bit of >> attention to that. > > Could the English version of

Re: kio-stash is in KDE Review

2017-06-29 Thread Arnav Dhamija
> I can't find your key on the openpgp key servers I've uploaded the keys. Please let me know if there still is any problem. > Please hold on the release. The Messages.sh was fixed only yesterday, so 1.0 > won't have translations. It may not be an issue, but I would pay a bit of > attention to th

Re: kio-stash is in KDE Review

2017-06-29 Thread Luigi Toscano
On Thursday, 29 June 2017 13:41:51 CEST Jonathan Riddell wrote: > Looks like you're getting there :) > > Tagging 1.0 > gpg: Signature made Thu 29 Jun 2017 12:31:50 BST using RSA key ID DBAF2267 > gpg: Can't check signature: No public key Please hold on the release. The Messages.sh was fixed only

Re: kio-stash is in KDE Review

2017-06-29 Thread Jonathan Riddell
Looks like you're getting there :) Tagging 1.0 gpg: Signature made Thu 29 Jun 2017 12:31:50 BST using RSA key ID DBAF2267 gpg: Can't check signature: No public key I can't find your key on the openpgp key servers gpg2 --send-keys DBAF2267 should do it Jonathan

Re: [kde-devel] Re: kio-stash is in KDE Review

2017-06-29 Thread Elvis Angelaccio
On Thu, Jun 29, 2017 at 8:11 AM, Arnav Dhamija wrote: > Thanks for the suggestions. I've made all these changes in the latest > commits. One thing bugging me is that the ID in the AppStream file > needs a .desktop file, but I don't have one as this is an application. > Should I leave it as it is o

Re: kio-stash is in KDE Review

2017-06-29 Thread Ben Cooksley
On Wed, Jun 28, 2017 at 1:27 PM, Arnav Dhamija wrote: > Yes. I have decided to move it under KDE ExtraGear Utils. I'm working > with the guide Boudhayan posted in the previous email to make a > tarball out of it to ship it for release. As a note for anyone doing moves in the future, please use "g

Re: [kde-devel] Re: kio-stash is in KDE Review

2017-06-28 Thread Arnav Dhamija
Thanks for the suggestions. I've made all these changes in the latest commits. One thing bugging me is that the ID in the AppStream file needs a .desktop file, but I don't have one as this is an application. Should I leave it as it is or create a .desktop file for the same? I'll be uploading the t

Re: [kde-devel] Re: kio-stash is in KDE Review

2017-06-28 Thread Jonathan Riddell
Versioning entirely depends on the project in question. For a library with API/ABI stability it's important to set the right version and update it on API/ABI changes. For anything else it's not too important but it's useful to have one so people can report bugs on a known version, however I'm n

Re: [kde-devel] Re: kio-stash is in KDE Review

2017-06-28 Thread Arnav Dhamija
Is the versioning part on that page still relevant? Many KDE applications I've seen just list the required version of a library as a single decimal separated string (e.g. KF5_MIN_VERSION "5.28.0" rather than splitting it into variables). Also, I have some confusion about AppStream procedure. > Yo

Re: [kde-devel] Re: kio-stash is in KDE Review

2017-06-28 Thread Boudhayan Gupta
Minor nitpicks: 1) Tag names should start with v, such as "v1.2.3" 2) You don't actually have to sign the tarball cryptographically, just give sysadmin a SHA2-256 or better hash out-of-band (i.e., through Phabricator which you access over HTTPS). Freundliche Grüße Boudhayan Gupta KDE e.V. - Sysad

Re: [kde-devel] Re: kio-stash is in KDE Review

2017-06-28 Thread Jonathan Riddell
The page was out of date so I made some updates. Let me know of any unclear or missing information. https://techbase.kde.org/ReleasingExtragearSoftware You need to remove kio-stash from kdereview in repo-metadata, this will mess up the translations. You have i18n() used but no Messages.sh to

Re: kio-stash is in KDE Review

2017-06-27 Thread Arnav Dhamija
Yes. I have decided to move it under KDE ExtraGear Utils. I'm working with the guide Boudhayan posted in the previous email to make a tarball out of it to ship it for release. On Wed, Jun 28, 2017 at 4:01 AM, Ben Cooksley wrote: > On Wed, Jun 21, 2017 at 8:27 PM, Boudhayan Gupta wrote: >> You us

Re: kio-stash is in KDE Review

2017-06-27 Thread Ben Cooksley
On Wed, Jun 21, 2017 at 8:27 PM, Boudhayan Gupta wrote: > You use something called "releaseme" to create a tarball, upload it to ftp > and ask Sysadmin to release it. Then you write a release announcement and > distro packagers pick it up. > > More detailed info here: https://techbase.kde.org/Rele

Re: kio-stash is in KDE Review

2017-06-21 Thread Boudhayan Gupta
You use something called "releaseme" to create a tarball, upload it to ftp and ask Sysadmin to release it. Then you write a release announcement and distro packagers pick it up. More detailed info here: https://techbase.kde.org/ReleasingExtragearSoftware Freundliche Grüße Boudhayan Gupta KDE e.V

Re: kio-stash is in KDE Review

2017-06-20 Thread Arnav Dhamija
Sounds great then. My question is - where are KDE Extragear apps actually distributed? Are they only available in repos, or are they distributed with mainline builds of Plasma distros such as Neon and Kubuntu? Also, are there any other follow up formalities I have to do to 'ship' this for good? O

Re: kio-stash is in KDE Review

2017-06-20 Thread Albert Astals Cid
El dimarts, 20 de juny de 2017, a les 11:24:49 CEST, Arnav Dhamija va escriure: > > ok, tests pass now here locally too, *but* they don't finish, i.e. the > > testdaemon process keeps running forever, does anyone else see this? > > It turns out I hadn't terminated the QProcess after the test case

Re: kio-stash is in KDE Review

2017-06-19 Thread Arnav Dhamija
> > ok, tests pass now here locally too, *but* they don't finish, i.e. the > testdaemon process keeps running forever, does anyone else see this? It turns out I hadn't terminated the QProcess after the test case had finished executing. This is fixed in the latest commit to master. Can you please

Re: kio-stash is in KDE Review

2017-06-19 Thread Albert Astals Cid
El dilluns, 19 de juny de 2017, a les 10:06:35 CEST, Jonathan Riddell va escriure: > Better as kio-extras in KDE Applications no? I've no idea, the original email didn't explain what kio-stash is. Ok, i went and read the README.md to me it really sounds really specialized, but if the world want

Re: kio-stash is in KDE Review

2017-06-19 Thread Albert Astals Cid
El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija va escriure: > Hi! > > I had made the kio-stash ioslave last year as part of my GSoC 2016 > Project. Now that most of the changes which I wished to make in > Dolphin relevant to the ioslave are part of master, I wish to ship the

Re: kio-stash is in KDE Review

2017-06-19 Thread Albert Astals Cid
El dilluns, 19 de juny de 2017, a les 14:30:22 CEST, Arnav Dhamija va escriure: > Thanks. I have fixed this and the kio-stash ioslave passes all the > test cases on CI here: > https://build-sandbox.kde.org/view/Extragear/job/Extragear%20kio-stash%20kf5 > -qt5%20SUSEQt5.9/ > > The build log for th

Re: kio-stash is in KDE Review

2017-06-19 Thread Jonathan Riddell
Better as kio-extras in KDE Applications no? Jonathan On 19 June 2017 at 10:00, Arnav Dhamija wrote: > Thanks. I have fixed this and the kio-stash ioslave passes all the > test cases on CI here: > https://build-sandbox.kde.org/view/Extragear/job/Extragear%20kio-stash%20kf5-qt5%20SUSEQt5.9/ > >

Re: kio-stash is in KDE Review

2017-06-19 Thread Arnav Dhamija
Thanks. I have fixed this and the kio-stash ioslave passes all the test cases on CI here: https://build-sandbox.kde.org/view/Extragear/job/Extragear%20kio-stash%20kf5-qt5%20SUSEQt5.9/ The build log for the same can be found here: https://build-sandbox.kde.org/view/Extragear/job/Extragear%20kio-sta

Re: kio-stash is in KDE Review

2017-06-18 Thread Albert Astals Cid
El dimecres, 14 de juny de 2017, a les 21:42:58 CEST, Arnav Dhamija va escriure: > Just to check I setup a brand new virtualbox with KDE Neon 5.8 LTS and > ran the following commands after cloning the repo and creating a build > directory: > > cmake -DCMAKE_INSTALL_PREFIX=/usr -DKDE_INSTALL_USE_Q

Re: kio-stash is in KDE Review

2017-06-15 Thread Ben Cooksley
On Thu, Jun 15, 2017 at 9:04 AM, Albert Astals Cid wrote: > El dimecres, 14 de juny de 2017, a les 21:42:58 CEST, Arnav Dhamija va > escriure: >> Just to check I setup a brand new virtualbox with KDE Neon 5.8 LTS and >> ran the following commands after cloning the repo and creating a build >> dire

Re: kio-stash is in KDE Review

2017-06-14 Thread Albert Astals Cid
El dimecres, 14 de juny de 2017, a les 21:42:58 CEST, Arnav Dhamija va escriure: > Just to check I setup a brand new virtualbox with KDE Neon 5.8 LTS and > ran the following commands after cloning the repo and creating a build > directory: > > cmake -DCMAKE_INSTALL_PREFIX=/usr -DKDE_INSTALL_USE_Q

Re: kio-stash is in KDE Review

2017-06-14 Thread Arnav Dhamija
Just to check I setup a brand new virtualbox with KDE Neon 5.8 LTS and ran the following commands after cloning the repo and creating a build directory: cmake -DCMAKE_INSTALL_PREFIX=/usr -DKDE_INSTALL_USE_QT_SYS_PATHS=TRUE .. make sudo make install kdeinit5 ...and then I ran the tests using 'ctes

Re: kio-stash is in KDE Review

2017-06-12 Thread Albert Astals Cid
El divendres, 9 de juny de 2017, a les 11:45:14 CEST, Arnav Dhamija va escriure: > > Do you mean i have to manually start a process for the tests to succeed? > > If installed correctly with kdeinit restarted and the Stash Daemon is > running in kded5, it is not required. However, I cannot recall

Re: kio-stash is in KDE Review

2017-06-08 Thread Arnav Dhamija
> Do you mean i have to manually start a process for the tests to succeed? If installed correctly with kdeinit restarted and the Stash Daemon is running in kded5, it is not required. However, I cannot recall what steps are needed for this to happen as I think it requires a system restart or logout

Re: kio-stash is in KDE Review

2017-06-08 Thread Albert Astals Cid
El dijous, 8 de juny de 2017, a les 16:25:02 CEST, Arnav Dhamija va escriure: > Yes, I will file a sysadmin ticket for the same. Until I do so, could > you send me the output of the test suite in a screenshot or as plain > text? > > The ioslave works by storing a list of virtual files and folders

Re: kio-stash is in KDE Review

2017-06-08 Thread Jonathan Riddell
In the git repo all the files are permission executable, they shouldn't be. There's no documentation. I'm unsure how hard a requirement this is these days. Use title case for name in src/iodaemon/stashnotifier.json When I use Dolphin to copy a file over I get a dialog daying "Could not copy.",

Re: kio-stash is in KDE Review

2017-06-08 Thread Arnav Dhamija
Yes, I will file a sysadmin ticket for the same. Until I do so, could you send me the output of the test suite in a screenshot or as plain text? The ioslave works by storing a list of virtual files and folders in a process running in the KDED, communicating with it over D-Bus. Hence, some of the t

Re: kio-stash is in KDE Review

2017-06-07 Thread Albert Astals Cid
El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija va escriure: > Hi! > > I had made the kio-stash ioslave last year as part of my GSoC 2016 > Project. Now that most of the changes which I wished to make in > Dolphin relevant to the ioslave are part of master, I wish to ship the

Re: kio-stash is in KDE Review

2017-06-07 Thread Arnav Dhamija
Hi everyone I have touched upon any concerns people have had with the ioslave in my previous email. If no one has any objections, I would like to ship this to KDE Extra Modules. More specifically, it will be suited for kde-extragear-utils, if that division is still relevant in KDE extragear. The s

Re: kio-stash is in KDE Review

2017-05-27 Thread Arnav Dhamija
First off, thanks for all the reviews! > We simulate a "virtual://" protocol[*] which can contain virtual > folders containing references to real files and folders. > I did not know that such a feature exists! It seems like this feature is Krusader specific without tapping into KIO as such? It

Re: kio-stash is in KDE Review

2017-05-27 Thread Albert Astals Cid
El dissabte, 27 de maig de 2017, a les 0:29:51 CEST, Boudhayan Gupta va escriure: > Hi, > > On 27 May 2017 at 00:20, Albert Astals Cid wrote: > > El divendres, 26 de maig de 2017, a les 23:48:18 CEST, Boudhayan Gupta va > > > > escriure: > >> Hi, > >> > >> On 26 May 2017 at 20:31, Elvis Angela

Re: kio-stash is in KDE Review

2017-05-26 Thread Boudhayan Gupta
Hi, On 27 May 2017 at 00:20, Albert Astals Cid wrote: > El divendres, 26 de maig de 2017, a les 23:48:18 CEST, Boudhayan Gupta va > escriure: >> Hi, >> >> On 26 May 2017 at 20:31, Elvis Angelaccio wrote: >> > * The dbus adaptor could probably use build-time generation via cmake, >> > rather than

Re: kio-stash is in KDE Review

2017-05-26 Thread Albert Astals Cid
El divendres, 26 de maig de 2017, a les 23:48:18 CEST, Boudhayan Gupta va escriure: > Hi, > > On 26 May 2017 at 20:31, Elvis Angelaccio wrote: > > * The dbus adaptor could probably use build-time generation via cmake, > > rather than being committed to the git repo. If you need an example look >

Re: kio-stash is in KDE Review

2017-05-26 Thread Boudhayan Gupta
Hi, On 26 May 2017 at 20:31, Elvis Angelaccio wrote: > * The dbus adaptor could probably use build-time generation via cmake, > rather than being committed to the git repo. If you need an example look at > the CMakeLists.txt in kio/src/kioexec (qt5_add_dbus_adaptor and friends). IIRC we did that

Re: kio-stash is in KDE Review

2017-05-26 Thread Elvis Angelaccio
On venerdì 26 maggio 2017 19:25:11 CEST, Arnav Dhamija wrote: Hi! I had made the kio-stash ioslave last year as part of my GSoC 2016 Project. Now that most of the changes which I wished to make in Dolphin relevant to the ioslave are part of master, I wish to ship the ioslave soon. The project i

Re: kio-stash is in KDE Review

2017-05-26 Thread A. Bikadorov
Hi Arnav, I don't know if you were aware of it, but Krusader has something very similar to your "stash://" protocol. We simulate a "virtual://" protocol[*] which can contain virtual folders containing references to real files and folders. It is persistent by saving/loading all lists to a config

kio-stash is in KDE Review

2017-05-26 Thread Arnav Dhamija
Hi! I had made the kio-stash ioslave last year as part of my GSoC 2016 Project. Now that most of the changes which I wished to make in Dolphin relevant to the ioslave are part of master, I wish to ship the ioslave soon. The project is now in KDE review and is awaiting feedback. The link for the s