Re: [Development] kdelibs coding style

2013-04-30 Thread Mitch Curtis
On 04/29/2013 10:31 PM, Olivier Goffart wrote: I support the change to optionally permit the braces. +1. Have always disliked this particular style. Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: [Development] kdelibs coding style

2013-04-29 Thread Giuseppe D'Angelo
On 29 April 2013 21:20, Thiago Macieira wrote: > On segunda-feira, 29 de abril de 2013 18.52.16, Giuseppe D'Angelo wrote: >> On 29 April 2013 18:43, Thiago Macieira wrote: >> > With that in mind, I would suggest we change *both* coding styles to >> > optionally permit the braces, and strongly sug

Re: [Development] kdelibs coding style

2013-04-29 Thread Olivier Goffart
gt; > This seems to be a documentation/policy only rule, as the kdelibs code is > > full of if's without braces. > > Remember that kdelibs isn't completely ported over to the kdelibs coding > style. > > So you may be seeing code that simply needs to be fixed w

Re: [Development] kdelibs coding style

2013-04-29 Thread Thiago Macieira
On segunda-feira, 29 de abril de 2013 18.52.16, Giuseppe D'Angelo wrote: > On 29 April 2013 18:43, Thiago Macieira wrote: > > With that in mind, I would suggest we change *both* coding styles to > > optionally permit the braces, and strongly suggest it for more-complex > > conditionals. > > In Qt

Re: [Development] kdelibs coding style

2013-04-29 Thread Giuseppe D'Angelo
On 29 April 2013 18:43, Thiago Macieira wrote: > > With that in mind, I would suggest we change *both* coding styles to > optionally permit the braces, and strongly suggest it for more-complex > conditionals. In Qt the braces are already mandatory if the condition spans over more than one line (w

Re: kdelibs coding style

2013-04-29 Thread Thiago Macieira
is > full of if's without braces. Remember that kdelibs isn't completely ported over to the kdelibs coding style. So you may be seeing code that simply needs to be fixed when it's next touched. The brace-on-one-line-if was adopted for KDE for a couple of good reasons: 1) when

Re: kdelibs coding style

2013-04-29 Thread Sergio Martins
have consistent formatting of the source code files it is recommended to make use of it. In short: Kdelibs coding style follows the Qt 4 coding style. """ So, even if you like braces, you can still use them. But at least we will have the same policy/recommendation all over.

kdelibs coding style

2013-04-29 Thread Sergio Martins
Hi, In the last PIM meeting in Berlin, we decided to give up on our beloved KDEPIM coding style. We figured out that it's more important to have a consistent style across KDE and Qt than to have the periodical discussions about identation and braces. The thing is, I just discovered that the