Re: git question

2013-07-28 Thread David Jarvie
On Saturday 27 Jul 2013 07:49:41 Lindsay Mathieson wrote: > On Sat, 27 Jul 2013 07:58:40 AM Martin Graesslin wrote: > > In case it's about submitting to review board, please have a look at the > > tool "post-review" [1] which is perfect for exactly this situation of > > reviewing patches from a lo

Re: git question

2013-07-27 Thread Lindsay Mathieson
On Sat, 27 Jul 2013 10:19:09 AM Thomas Lübking wrote: > Not trivially. > Master might have progressed and differs from "my-branch" > You'll then spam your patch with reverting all the stuff that has meanwhile > been changed in master. > > -> First rebase your branch on (origin/)master, then the ab

Re: git question

2013-07-27 Thread Lindsay Mathieson
On Sat, 27 Jul 2013 10:19:09 AM Thomas Lübking wrote: > Not trivially. > Master might have progressed and differs from "my-branch" > You'll then spam your patch with reverting all the stuff that has meanwhile > been changed in master. Thanks Thomas -- Lindsay signature.asc Description: This is

Re: git question

2013-07-27 Thread Thomas Lübking
On Samstag, 27. Juli 2013 06:30:11 CEST, Lindsay Mathieson wrote: I've made changes in a private branch and and want to create a diff to submit for application against master. Would this be the correct command? git diff master..my-branch Not trivially. Master might have progressed and diff

Re: git question

2013-07-27 Thread Martin Graesslin
On Saturday 27 July 2013 17:55:37 Lindsay Mathieson wrote: > On Sat, 27 Jul 2013 09:46:23 AM Martin Graesslin wrote: > > * review title > > * review comment > > Don't see how they could be done automatically since its dependant on the > actually patch. I usually have a range of commits to work wit

Re: git question

2013-07-27 Thread Lindsay Mathieson
On Sat, 27 Jul 2013 09:46:23 AM Martin Graesslin wrote: > * review title > * review comment Don't see how they could be done automatically since its dependant on the actually patch. I usually have a range of commits to work with. > post-review -g --branch=KDE/4.11 --parent=KDE/4.11 -o --userna

Re: git question

2013-07-27 Thread Martin Graesslin
On Saturday 27 July 2013 16:49:41 Lindsay Mathieson wrote: > On Sat, 27 Jul 2013 07:58:40 AM Martin Graesslin wrote: > > In case it's about submitting to review board, please have a look at the > > tool "post-review" [1] which is perfect for exactly this situation of > > reviewing patches from a l

Re: git question

2013-07-26 Thread Lindsay Mathieson
On Sat, 27 Jul 2013 07:58:40 AM Martin Graesslin wrote: > In case it's about submitting to review board, please have a look at the > tool "post-review" [1] which is perfect for exactly this situation of > reviewing patches from a local branch. Yup, not really seeing it being easier. Still have t

Re: git question

2013-07-26 Thread Lindsay Mathieson
On Sat, 27 Jul 2013 07:58:40 AM Martin Graesslin wrote: > In case it's about submitting to review board, please have a look at the > tool "post-review" [1] which is perfect for exactly this situation of > reviewing patches from a local branch. I'll give it another spin but in the past I've found

Re: git question

2013-07-26 Thread Martin Graesslin
On Saturday 27 July 2013 14:30:11 Lindsay Mathieson wrote: > I've made changes in a private branch and and want to create a diff to > submit for application against master. Would this be the correct command? > > git diff master..my-branch In case it's about submitting to review board, please hav

git question

2013-07-26 Thread Lindsay Mathieson
I've made changes in a private branch and and want to create a diff to submit for application against master. Would this be the correct command? git diff master..my-branch thanks, -- Lindsay signature.asc Description: This is a digitally signed message part. >> Visit http://mail.kde.org/ma