Re: Review Request 125818: Use KDE_INSTALL_DBUSINTERFACEDIR to install dbus interfaces

2015-10-27 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125818/ --- (Updated Oct. 27, 2015, 9:59 p.m.) Status -- This change has been ma

Re: Review Request 125818: Use KDE_INSTALL_DBUSINTERFACEDIR to install dbus interfaces

2015-10-27 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125818/#review87546 --- Ship it! Ship It! - Vishesh Handa On Oct. 27, 2015, 6:53 p

Re: Review Request 125818: Use KDE_INSTALL_DBUSINTERFACEDIR to install dbus interfaces

2015-10-27 Thread Heiko Becker
> On Okt. 27, 2015, 6:22 nachm., Vishesh Handa wrote: > > I really have no idea about this. If you're sure about this go ahead. I previously put up a review for kwallet: https://git.reviewboard.kde.org/r/125819/ which has been accepted in the meatime. This also has been done for other framew

Re: Review Request 125818: Use KDE_INSTALL_DBUSINTERFACEDIR to install dbus interfaces

2015-10-27 Thread Heiko Becker
Vishesh Handa. Changes --- Adjusted to match similar changes to kwallet Summary (updated) - Use KDE_INSTALL_DBUSINTERFACEDIR to install dbus interfaces Repository: baloo Description (updated) --- ...and use PATH_VARS to make the config file work with absolute paths. Two

Re: Review Request 125818: Use KDE_INSTALL_FULL_DBUSINTERFACEDIR to install dbus interfaces

2015-10-27 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125818/#review87535 --- I really have no idea about this. If you're sure about this go

Review Request 125818: Use KDE_INSTALL_FULL_DBUSINTERFACEDIR to install dbus interfaces

2015-10-26 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125818/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti

Re: dbus interfaces

2014-04-24 Thread Christophe Giboudeaux
R is the right variable. > Nope, KDE4_DBUS_INTERFACES_DIR is the "kdelibs dbus interfaces dir". Baloo may be installed in a different prefix. The solution: Patch BalooConfig.cmake.in to export Baloo's interfaces dir. Christophe signature.asc Description: This is a digi

Re: dbus interfaces

2014-04-23 Thread Lindsay Mathieson
On Thu, 24 Apr 2014 07:54:43 AM Alexander Mezin wrote: > I think > KDE4_DBUS_INTERFACES_DIR is the right variable. That did it, thanks. -- Lindsay signature.asc Description: This is a digitally signed message part. >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <

Re: dbus interfaces

2014-04-23 Thread Alexander Mezin
2014-04-24 6:52 GMT+07:00 Lindsay Mathieson : > it works, but don't know if DBUS_INTERFACES_INSTALL_DIR is portable. AFAIK *_INSTALL_DIRs depend on CMAKE_INSTALL_PREFIX. I think KDE4_DBUS_INTERFACES_DIR is the right variable. >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubs

dbus interfaces

2014-04-23 Thread Lindsay Mathieson
Is this the right cmake macro for adding dbus interfaces? qt4_add_dbus_interface(kcm_file_SRCS ${DBUS_INTERFACES_INSTALL_DIR}/org.kde.baloo.file.indexer.xml baloofileindexerinterface) it works, but don't know if DBUS_INTERFACES_INSTALL_DIR is portable. -- Lindsay signature.asc Descri