Re: Test Failures Fatal by Default in KDE CI

2025-03-19 Thread Kristen McWilliam
gt; > > > After the transition period, test failures will become fatal by > default. > > > > > > > > Additionally: > > > > - The legacy `require-passing-tests-on` option will be removed. > > > > - We will communicate the

Re: Test Failures Fatal by Default in KDE CI

2025-03-19 Thread Albert Astals Cid
gt; We encourage all maintainers to review and update their CI > > > configurations > > > accordingly. Your proactive adjustments and feedback will help ensure a > > > smooth transition and maintain the high quality of KDE projects. > > > > > > If your project

Re: Test Failures Fatal by Default in KDE CI

2025-03-19 Thread Albert Astals Cid
listed. > > If some tests are failing because the Windows CI can't handle certain GUI > tests, prefer conditionally skipping only those tests on Windows CI runs by > adding the following to the problematic tests: > > ```cpp > if (qEnvironmentVariableIntValue("KDECI_C

Re: Test Failures Fatal by Default in KDE CI

2025-03-18 Thread Ingo Klöcker
On Dienstag, 18. März 2025 10:12:06 Mitteleuropäische Normalzeit Sune Vuorela wrote: > On 2025-03-18, Ingo Klöcker wrote: > > Options: > > require-passing-tests-on: ['Linux', 'FreeBSD'] > > > > ``` > > and there are builds for Linux, FreeBSD, and Windows. > > > > I suppose I can safely add >

Re: Test Failures Fatal by Default in KDE CI

2025-03-18 Thread Ingo Klöcker
On Montag, 17. März 2025 14:54:24 Mitteleuropäische Normalzeit Kristen McWilliam wrote: > ## TLDR > > Test failures will be fatal by default in KDE CI. Use > `allow-failing-tests-on` to opt out temporarily. Review and update your CI > configurations to ensure a smooth transition. Reach out for su

Re: Test Failures Fatal by Default in KDE CI

2025-03-18 Thread Sune Vuorela
On 2025-03-18, Ingo Klöcker wrote: > For libkleo we do have Windows CI. But those tests seems green? or are they flaky? /Sune

Re: Test Failures Fatal by Default in KDE CI

2025-03-18 Thread Sune Vuorela
On 2025-03-18, Ingo Klöcker wrote: > Options: > require-passing-tests-on: ['Linux', 'FreeBSD'] > ``` > and there are builds for Linux, FreeBSD, and Windows. > > I suppose I can safely add > ``` > allow-failing-tests-on: [ 'Windows' ] > ``` > now _additionally_ to the require-passing-tests-on.

Test Failures Fatal by Default in KDE CI

2025-03-17 Thread Kristen McWilliam
p if (qEnvironmentVariableIntValue("KDECI_CANNOT_CREATE_WINDOWS")) { QSKIP("KDE CI can't create a window on this platform, skipping this test"); } ``` If you have any questions or need support during this process, reply here or in the accompanying Discourse thread: ht