Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-18 Thread Anthony Fieroni
> On Ян. 9, 2017, 9:22 след обяд, Stefan Brüns wrote: > > src/file/extractor/app.cpp, line 165 > > > > > > Thats plain wrong, results from multiple extractors are combined! > > Anthony Fieroni wrote: > I'm w

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-09 Thread Anthony Fieroni
> On Ян. 9, 2017, 9:22 след обяд, Stefan Brüns wrote: > > src/file/extractor/app.cpp, line 81 > > > > > > Bogus constant > > Anthony Fieroni wrote: > I want to be > 10 And especially power of 2 - Anthony

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-09 Thread Anthony Fieroni
> On Ян. 9, 2017, 9:22 след обяд, Stefan Brüns wrote: > > src/file/extractor/app.cpp, line 165 > > > > > > Thats plain wrong, results from multiple extractors are combined! I'm waiting to see a extractor relatio

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-09 Thread Anthony Fieroni
> On Ян. 9, 2017, 8:50 след обяд, Albert Astals Cid wrote: > > src/tools/balooctl/indexer.cpp, line 54 > > > > > > Why? Aren't extractors independent? What has one giving no output have > > to do with the next gi

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-09 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/#review101909 --- src/file/extractor/app.cpp (line 81)

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-09 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/#review101914 --- src/tools/balooctl/indexer.cpp (line 54)

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-08 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/ --- (Updated Ян. 9, 2017, 7:48 преди обяд) Review request for Baloo, Boudhaya

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-03 Thread Anthony Fieroni
> On Jan. 3, 2017, 12:51 a.m., Albert Astals Cid wrote: > > Without knowing anything about baloo this looks totally wrong > > > > QList exList = > > m_extractorCollection.fetchExtractors(mimetype); > > > > why would not you want to iterate over all the iterators that support a > > given mim

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-03 Thread Stefan Brüns
> On Jan. 2, 2017, 10:51 p.m., Albert Astals Cid wrote: > > Without knowing anything about baloo this looks totally wrong > > > > QList exList = > > m_extractorCollection.fetchExtractors(mimetype); > > > > why would not you want to iterate over all the iterators that support a > > given mim

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-03 Thread Anthony Fieroni
> On Jan. 3, 2017, 12:51 a.m., Albert Astals Cid wrote: > > Without knowing anything about baloo this looks totally wrong > > > > QList exList = > > m_extractorCollection.fetchExtractors(mimetype); > > > > why would not you want to iterate over all the iterators that support a > > given mim

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-03 Thread Jan Kundrát
> On Jan. 2, 2017, 10:51 p.m., Albert Astals Cid wrote: > > Without knowing anything about baloo this looks totally wrong > > > > QList exList = > > m_extractorCollection.fetchExtractors(mimetype); > > > > why would not you want to iterate over all the iterators that support a > > given mim

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-02 Thread Anthony Fieroni
> On Ян. 3, 2017, 12:51 преди обяд, Albert Astals Cid wrote: > > Without knowing anything about baloo this looks totally wrong > > > > QList exList = > > m_extractorCollection.fetchExtractors(mimetype); > > > > why would not you want to iterate over all the iterators that support a > > give

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/#review101748 --- Without knowing anything about baloo this looks totally wron

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-01 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/#review101694 --- ping - Anthony Fieroni On Дек. 27, 2016, 7:34 преди обяд,

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2016-12-27 Thread Anthony Fieroni
> On Дек. 27, 2016, 4:29 след обяд, Michael Stemle wrote: > > src/tools/balooctl/indexer.cpp, line 53 > > > > > > This may be a dumb comment, but if there are multiple extractors, each > > potentially pulling met

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2016-12-27 Thread Michael Stemle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/#review101591 --- src/tools/balooctl/indexer.cpp (line 53)

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2016-12-26 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/ --- (Updated Дек. 27, 2016, 7:34 преди обяд) Review request for Baloo and Vis

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2016-12-26 Thread Anthony Fieroni
> On Дек. 26, 2016, 2:24 преди обяд, Aleix Pol Gonzalez wrote: > > src/file/extractor/app.cpp, line 85 > > > > > > FWIW, something looks incorrect here, as it seems be using Urls as > > paths. I know it's unrelat

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2016-12-26 Thread Aleix Pol Gonzalez
> On Dec. 26, 2016, 1:24 a.m., Aleix Pol Gonzalez wrote: > > src/file/extractor/app.cpp, line 85 > > > > > > FWIW, something looks incorrect here, as it seems be using Urls as > > paths. I know it's unrelated but

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2016-12-25 Thread Anthony Fieroni
> On Дек. 26, 2016, 2:24 преди обяд, Aleix Pol Gonzalez wrote: > > src/file/extractor/app.cpp, line 85 > > > > > > FWIW, something looks incorrect here, as it seems be using Urls as > > paths. I know it's unrelat

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2016-12-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/#review101575 --- src/file/extractor/app.cpp (line 81)

Review Request 129703: [baloo_file_extractor] Limit CPU usage

2016-12-25 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti