Re: Review Request 129182: CLazy fixes: use const ref in for loop instead object

2016-10-14 Thread Christian Ehrlicher
> On Oct. 14, 2016, 8:58 p.m., Aleix Pol Gonzalez wrote: > > src/engine/transaction.cpp, line 457 > > > > > > add const The question here is - why create a temporary QList here at all - I'm now using Q_FOREACH

Re: Review Request 129182: CLazy fixes: use const ref in for loop instead object

2016-10-14 Thread Christian Ehrlicher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129182/ --- (Updated Oct. 14, 2016, 9:11 p.m.) Review request for Baloo. Changes --

Re: Review Request 129182: CLazy fixes: use const ref in for loop instead object

2016-10-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129182/#review17 --- src/engine/transaction.cpp (line 457)

Review Request 129182: CLazy fixes: use const ref in for loop instead object

2016-10-14 Thread Christian Ehrlicher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129182/ --- Review request for Baloo. Repository: baloo Description --- While