Re: Review Request 128738: Quote all prefix search values, if operator is = or :.

2016-09-07 Thread James Smith
> On Sept. 4, 2016, 9:25 a.m., Vishesh Handa wrote: > > This breaks the default behavior of searching and makes it hard to reason > > what is going on. > > > > Eg - `baloosearch 'tag:Death Fire'` and `baloosearch tag:Death Fire` now > > yield different results since "Fire" is considered part o

Re: Review Request 128738: Quote all prefix search values, if operator is = or :.

2016-09-04 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128738/#review98859 --- This breaks the default behavior of searching and makes it ha

Re: Review Request 128738: Quote all prefix search values, if operator is = or :.

2016-08-31 Thread James Smith
> On Aug. 29, 2016, 8:13 a.m., Pinak Ahuja wrote: > > Hi, could you add a little more details as to why this is needed/what cases > > it improves or fixes. And maybe some unit tests would be nice. :) The arguments with quotes are stripped by the shell, breaking any results for queries with spa

Re: Review Request 128738: Quote all prefix search values, if operator is = or :.

2016-08-29 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128738/#review98765 --- Hey James. I'm a little busy right now, but I will have time

Re: Review Request 128738: Quote all prefix search values, if operator is = or :.

2016-08-29 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128738/#review98763 --- Hi, could you add a little more details as to why this is nee

Re: Review Request 128738: Quote all prefix search values, if operator is = or :.

2016-08-23 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128738/ --- (Updated Aug. 24, 2016, 3:58 a.m.) Review request for Baloo. Changes --