Re: Review Request 127179: Add external extractor plugin support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127179/ --- (Updated Feb. 27, 2016, 6:06 a.m.) Status -- This change has been ma

Re: Review Request 127179: Add external extractor plugin support

> On Feb. 26, 2016, 8:48 p.m., Boudhayan Gupta wrote: > > src/externalextractor.cpp, line 98 > > > > > > Does it not build without the const (in Q_D(const Ext...))? You > > shouldn't have to put qualifiers inside

Re: Review Request 127179: Add external extractor plugin support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127179/ --- (Updated Feb. 27, 2016, 4:51 a.m.) Review request for Baloo, Boudhayan Gu

Re: Review Request 127179: Add external extractor plugin support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127179/#review92816 --- Fix it, then Ship it! Awesome. I'm giving you a Ship It,

Re: Review Request 127179: Add external extractor plugin support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127179/ --- (Updated Feb. 26, 2016, 6:50 p.m.) Review request for Baloo, Boudhayan Gu

Re: Review Request 127179: Add external extractor plugin support

> On Feb. 25, 2016, 9:18 p.m., Pinak Ahuja wrote: > > src/externalextractor.cpp, line 104 > > > > > > You should use the asynchronous api instead of blocking the event loop > > by calling waitForFinished() > >

Re: Review Request 127179: Add external extractor plugin support

> On Feb. 26, 2016, 2:48 a.m., Pinak Ahuja wrote: > > src/externalextractor.cpp, line 104 > > > > > > You should use the asynchronous api instead of blocking the event loop > > by calling waitForFinished() > >

Re: Review Request 127179: Add external extractor plugin support

> On Feb. 25, 2016, 9:18 p.m., Pinak Ahuja wrote: > > src/externalextractor.cpp, line 104 > > > > > > You should use the asynchronous api instead of blocking the event loop > > by calling waitForFinished() > >

Re: Review Request 127179: Add external extractor plugin support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127179/#review92783 --- src/externalextractor.cpp (line 104)

Re: Review Request 127179: Add external extractor plugin support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127179/#review92777 --- The logic is more or less sound. You'll have to solve these i

Re: Review Request 127179: Add external extractor plugin support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127179/ --- (Updated Feb. 25, 2016, 6:32 p.m.) Review request for Baloo, KDE Framewor

Re: Review Request 127179: Add external extractor plugin support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127179/ --- (Updated Feb. 25, 2016, 6:31 p.m.) Review request for Baloo. Summary (u