Re: Review Request 127178: Added writer plugin support

2016-04-10 Thread Varun Joshi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127178/ --- (Updated April 10, 2016, 11:45 a.m.) Status -- This change has been

Re: Review Request 127178: Added writer plugin support

2016-03-03 Thread Varun Joshi
> On March 1, 2016, 11:03 a.m., Pinak Ahuja wrote: > > autotests/taglibwritertest.cpp, line 53 > > > > > > The test needs to be fixed. What exactly are the wierd moc errors you > > are getting? Lets find out why

Re: Review Request 127178: Added writer plugin support

2016-03-03 Thread Pinak Ahuja
> On March 1, 2016, 11:03 a.m., Pinak Ahuja wrote: > > autotests/taglibwritertest.cpp, line 53 > > > > > > The test needs to be fixed. What exactly are the wierd moc errors you > > are getting? Lets find out why

Re: Review Request 127178: Added writer plugin support

2016-03-02 Thread Boudhayan Gupta
> On March 1, 2016, 4:33 p.m., Pinak Ahuja wrote: > > autotests/taglibwritertest.cpp, line 53 > > > > > > The test needs to be fixed. What exactly are the wierd moc errors you > > are getting? Lets find out why t

Re: Review Request 127178: Added writer plugin support

2016-03-01 Thread Varun Joshi
> On March 1, 2016, 11:03 a.m., Pinak Ahuja wrote: > > autotests/taglibwritertest.cpp, line 53 > > > > > > The test needs to be fixed. What exactly are the wierd moc errors you > > are getting? Lets find out why

Re: Review Request 127178: Added writer plugin support

2016-03-01 Thread Pinak Ahuja
> On March 1, 2016, 11:03 a.m., Pinak Ahuja wrote: > > src/writers/taglibwriter.cpp, line 23 > > > > > > "QStringLiteral cannot be used to initialize an array of QStrings" > > http://doc.qt.io/qt-5/qstring.htm

Re: Review Request 127178: Added writer plugin support

2016-03-01 Thread Boudhayan Gupta
> On March 1, 2016, 4:33 p.m., Pinak Ahuja wrote: > > src/writers/taglibwriter.cpp, line 23 > > > > > > "QStringLiteral cannot be used to initialize an array of QStrings" > > http://doc.qt.io/qt-5/qstring.html

Re: Review Request 127178: Added writer plugin support

2016-03-01 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127178/#review92981 --- The change looks good to me :) But we need to fix the test.

Re: Review Request 127178: Added writer plugin support

2016-02-28 Thread Varun Joshi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127178/ --- (Updated Feb. 28, 2016, 2:17 p.m.) Status -- This change has been ma

Re: Review Request 127178: Added writer plugin support

2016-02-28 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127178/#review92850 --- Ship it! I still have reservations about the direct use of

Re: Review Request 127178: Added writer plugin support

2016-02-28 Thread Varun Joshi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127178/ --- (Updated Feb. 28, 2016, 1:52 p.m.) Review request for Baloo, Boudhayan Gu

Review Request 127178: Added writer plugin support

2016-02-25 Thread Varun Joshi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127178/ --- Review request for Baloo, KDE Frameworks, Boudhayan Gupta, and Vishesh Hand