Re: Review Request 126227: Fix incomplete or duplicate search result with mtime

2015-12-14 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126227/ --- (Updated Dec. 15, 2015, 5:28 a.m.) Status -- This change has been ma

Re: Review Request 126227: Fix incomplete or duplicate search result with mtime

2015-12-14 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126227/#review89508 --- Ship it! - Vishesh Handa On Dec. 6, 2015, 6:03 p.m., Xuetia

Re: Review Request 126227: Fix incomplete or duplicate search result with mtime

2015-12-06 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126227/ --- (Updated Dec. 6, 2015, 6:03 p.m.) Review request for Baloo and Vishesh Ha

Re: Review Request 126227: Fix incomplete or duplicate search result with mtime

2015-12-06 Thread Xuetian Weng
> On Dec. 6, 2015, 11:47 a.m., Vishesh Handa wrote: > > src/engine/mtimedb.cpp, line 98 > > > > > > Could you please sort these values as well? This is possible why we are > > getting duplicates. The WriteTransac

Re: Review Request 126227: Fix incomplete or duplicate search result with mtime

2015-12-06 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126227/#review89170 --- If you have the time, some automated tests for this would be f

Re: Review Request 126227: Fix incomplete or duplicate search result with mtime

2015-12-05 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126227/ --- (Updated Dec. 6, 2015, 5:29 a.m.) Review request for Baloo and Vishesh Ha

Re: Review Request 126227: Fix incomplete or duplicate search result with mtime

2015-12-04 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126227/#review89141 --- src/engine/vectorpostingiterator.cpp (line 43)

Review Request 126227: Fix incomplete or duplicate search result with mtime

2015-12-02 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126227/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti