Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

> On Oct. 10, 2015, 12:58 a.m., Boudhayan Gupta wrote: > > src/lib/searchstore.cpp, line 126 > > > > > > Shouldn't this be qMin(size, offset + limit)? > > Vishesh Handa wrote: > I don't think it matters. >

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

> On Oct. 9, 2015, 7:28 p.m., Boudhayan Gupta wrote: > > src/lib/searchstore.cpp, line 126 > > > > > > Shouldn't this be qMin(size, offset + limit)? I don't think it matters. If there aren't any more elements t

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125544/#review86568 --- src/lib/searchstore.cpp (line 122)

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125544/ --- (Updated Oct. 9, 2015, 6:57 p.m.) Status -- This change has been mar

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125544/#review86564 --- Ship it! Awesome work. Thanks a lot for taking care of this.

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125544/ --- (Updated Oct. 9, 2015, 5:54 p.m.) Review request for Baloo, Release Team

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125544/ --- (Updated Oct. 9, 2015, 5:47 p.m.) Review request for Baloo, Release Team

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

> On Oct. 9, 2015, 11:21 a.m., Vishesh Handa wrote: > > src/lib/searchstore.cpp, line 103 > > > > > > Say we have 50 results > > > > limit = 10 > > offset = 5 > > > > So we want results from

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

> On Oct. 9, 2015, 11:21 a.m., Vishesh Handa wrote: > > src/lib/searchstore.cpp, line 103 > > > > > > Say we have 50 results > > > > limit = 10 > > offset = 5 > > > > So we want results from

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

> On Oct. 9, 2015, 11:21 a.m., Vishesh Handa wrote: > > src/lib/searchstore.cpp, line 114 > > > > > > The entire code in this else case is absolutely rubbish. The person > > implementing it should feel bad (me).

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

> On Oct. 9, 2015, 11:49 a.m., Emmanuel Pescosta wrote: > > Should fix bug 348902 :) I don't think it's the same bug. The bug that I tries to fixed here is introduced between 5.14 - 5.15. - Xuetian --- This is an automatically generate

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125544/#review86551 --- Can someone check if this also fixes display in the timeline:/

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125544/#review86541 --- Should fix bug 348902 :) - Emmanuel Pescosta On Oct. 9, 201

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125544/#review86535 --- I'm adding the release team since maybe we can delay the relea

Review Request 125544: Fix limit/offset handling when sort option is no sort.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125544/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti