Re: Review Request 125481: Port balooctl check to work with new architecture

2015-10-02 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125481/ --- (Updated Oct. 2, 2015, 5:34 p.m.) Status -- This change has been mar

Re: Review Request 125481: Port balooctl check to work with new architecture

2015-10-02 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125481/#review86244 --- Ship it! src/file/unindexedfileiterator.cpp (line 97)

Re: Review Request 125481: Port balooctl check to work with new architecture

2015-10-02 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125481/ --- (Updated Oct. 2, 2015, 2:57 p.m.) Review request for Baloo and Vishesh Ha

Re: Review Request 125481: Port balooctl check to work with new architecture

2015-10-02 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125481/ --- (Updated Oct. 2, 2015, 2:55 p.m.) Review request for Baloo and Vishesh Ha

Re: Review Request 125481: Port balooctl check to work with new architecture

2015-10-02 Thread Vishesh Handa
> On Oct. 2, 2015, 1:28 p.m., Vishesh Handa wrote: > > src/file/unindexedfileindexer.cpp, line 59 > > > > > > Are you sure this is the right thing to be doing? I'm imagining the > > case when the filename has cha

Re: Review Request 125481: Port balooctl check to work with new architecture

2015-10-02 Thread Pinak Ahuja
> On Oct. 2, 2015, 1:28 p.m., Vishesh Handa wrote: > > src/file/unindexedfileindexer.cpp, line 59 > > > > > > Are you sure this is the right thing to be doing? I'm imagining the > > case when the filename has cha

Re: Review Request 125481: Port balooctl check to work with new architecture

2015-10-02 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125481/#review86228 --- src/file/unindexedfileindexer.cpp (line 59)

Review Request 125481: Port balooctl check to work with new architecture

2015-10-02 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125481/ --- Review request for Baloo and Vishesh Handa. Bugs: 353011 http://bugs.