Re: Review Request 125430: FileContentIndexer: Fix threading issues

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125430/ --- (Updated Sept. 30, 2015, 4:41 p.m.) Status -- This change has been d

Re: Review Request 125430: FileContentIndexer: Fix threading issues

> On Sept. 29, 2015, 3:10 p.m., Pinak Ahuja wrote: > > Oh wait, I don't think this is needed all slots that modify m_monitors run > > in the creation/main thread also m_currentFile is updated in the > > slotIndexingFile and read in the QProperty getter (I should probably make > > it const) bot

Re: Review Request 125430: FileContentIndexer: Fix threading issues

> On Sept. 29, 2015, 2:56 p.m., Pinak Ahuja wrote: > > src/file/filecontentindexer.cpp, line 80 > > > > > > Maybe we can move this below m_filePath = filePath; ? > > > > Wouldn't make a lot of difference

Re: Review Request 125430: FileContentIndexer: Fix threading issues

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125430/#review86118 --- Oh wait, I don't think this is needed all slots that modify m_

Re: Review Request 125430: FileContentIndexer: Fix threading issues

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125430/#review86116 --- Ship it! Makes sense, didn't realize multiple monitors can ca

Re: Review Request 125430: FileContentIndexer: Fix threading issues

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125430/ --- (Updated Sept. 27, 2015, 9:48 p.m.) Review request for Baloo. Repositor

Review Request 125430: FileContentIndexer: Fix threading issues

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125430/ --- Review request for Baloo. Repository: baloo Description --- See di