Re: Review Request 125362: Avoid QByteArray::fromRawData

2015-09-28 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125362/ --- (Updated Sept. 29, 2015, 4:59 a.m.) Status -- This change has been m

Re: Review Request 125362: Avoid QByteArray::fromRawData

2015-09-28 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125362/#review86076 --- Ship it! The more I think I about this, the more it makes sen

Re: Review Request 125362: Avoid QByteArray::fromRawData

2015-09-25 Thread Igor Poboiko
> On Сен. 25, 2015, 3:12 д.п., Milian Wolff wrote: > > src/codecs/doctermscodec.cpp, line 73 > > > > > > this and the below cases look fine to me - anything else sounds super > > dangerous and could leak to subtl

Re: Review Request 125362: Avoid QByteArray::fromRawData

2015-09-24 Thread Milian Wolff
> On Sept. 25, 2015, 3:12 a.m., Milian Wolff wrote: > > src/codecs/doctermscodec.cpp, line 73 > > > > > > this and the below cases look fine to me - anything else sounds super > > dangerous and could leak to subt

Re: Review Request 125362: Avoid QByteArray::fromRawData

2015-09-24 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125362/#review85910 --- src/codecs/doctermscodec.cpp (line 63)

Re: Review Request 125362: Avoid QByteArray::fromRawData

2015-09-24 Thread Vishesh Handa
> On Sept. 23, 2015, 2:59 p.m., Vishesh Handa wrote: > > Hmm. This is actually an optimization I care about. > > Do you think you could share your `~/.local/share/baloo/index` file. That > > way I will be able to reproduce it and see exactly where/why the data is > > changing? > > > > Btw, aw

Re: Review Request 125362: Avoid QByteArray::fromRawData

2015-09-23 Thread Igor Poboiko
> On Сен. 23, 2015, 2:59 п.п., Vishesh Handa wrote: > > Hmm. This is actually an optimization I care about. > > Do you think you could share your `~/.local/share/baloo/index` file. That > > way I will be able to reproduce it and see exactly where/why the data is > > changing? > > > > Btw, awe

Re: Review Request 125362: Avoid QByteArray::fromRawData

2015-09-23 Thread Boudhayan Gupta
> On Sept. 23, 2015, 8:29 p.m., Vishesh Handa wrote: > > Hmm. This is actually an optimization I care about. > > Do you think you could share your `~/.local/share/baloo/index` file. That > > way I will be able to reproduce it and see exactly where/why the data is > > changing? > > > > Btw, aw

Re: Review Request 125362: Avoid QByteArray::fromRawData

2015-09-23 Thread Vishesh Handa
> On Sept. 23, 2015, 2:59 p.m., Vishesh Handa wrote: > > Hmm. This is actually an optimization I care about. > > Do you think you could share your `~/.local/share/baloo/index` file. That > > way I will be able to reproduce it and see exactly where/why the data is > > changing? > > > > Btw, aw

Re: Review Request 125362: Avoid QByteArray::fromRawData

2015-09-23 Thread Igor Poboiko
> On Сен. 23, 2015, 2:59 п.п., Vishesh Handa wrote: > > Hmm. This is actually an optimization I care about. > > Do you think you could share your `~/.local/share/baloo/index` file. That > > way I will be able to reproduce it and see exactly where/why the data is > > changing? > > > > Btw, awe

Re: Review Request 125362: Avoid QByteArray::fromRawData

2015-09-23 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125362/#review85830 --- Hmm. This is actually an optimization I care about. Do you th

Review Request 125362: Avoid QByteArray::fromRawData

2015-09-23 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125362/ --- Review request for Baloo. Repository: baloo Description --- I've n