Re: Review Request 125359: Remove baloo-monitor from baloo

2015-09-25 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125359/ --- (Updated Sept. 25, 2015, 7:55 a.m.) Status -- This change has been m

Re: Review Request 125359: Remove baloo-monitor from baloo

2015-09-24 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125359/#review85902 --- Ship it! src/qml/experimental/monitor.cpp (line 127)

Re: Review Request 125359: Remove baloo-monitor from baloo

2015-09-24 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125359/ --- (Updated Sept. 24, 2015, 4:52 p.m.) Review request for Baloo and Vishesh

Re: Review Request 125359: Remove baloo-monitor from baloo

2015-09-24 Thread Pinak Ahuja
> On Sept. 23, 2015, 2:20 p.m., Hrvoje Senjan wrote: > > src/tools/CMakeLists.txt, line 4 > > > > > > Please mention in the changelog that users that will upgrade to KF5 > > 5.15 will lose the app. I don't think

Re: Review Request 125359: Remove baloo-monitor from baloo

2015-09-24 Thread Pinak Ahuja
> On Sept. 23, 2015, 2:08 p.m., Vishesh Handa wrote: > > Maybe you could split this into one patch where you remove the monitor and > > one in which you introduce the experimental qml monitor.h? > > > > Feel free to ship the one where you remove it. We've introduced the experimental monitor al

Re: Review Request 125359: Remove baloo-monitor from baloo

2015-09-23 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125359/#review85827 --- src/tools/CMakeLists.txt

Re: Review Request 125359: Remove baloo-monitor from baloo

2015-09-23 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125359/#review85824 --- Maybe you could split this into one patch where you remove the

Review Request 125359: Remove baloo-monitor from baloo

2015-09-23 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125359/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti