Re: Review Request 125302: Balooctl: Add Config option

2015-09-18 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125302/ --- (Updated Sept. 19, 2015, 12:59 a.m.) Status -- This change has been

Re: Review Request 125302: Balooctl: Add Config option

2015-09-18 Thread Pinak Ahuja
> On Sept. 18, 2015, 8:04 p.m., Pinak Ahuja wrote: > > Looks good some minor suggestions, > > * Forgot to add the description for the config command to balooctl :) > > * maybe we can check for plural as well as singular forms of commands > > (includeFolder(s))? > > * If I type in balooctl config

Re: Review Request 125302: Balooctl: Add Config option

2015-09-18 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125302/#review85637 --- Ship it! Looks good some minor suggestions, * Forgot to add t

Review Request 125302: Balooctl: Add Config option

2015-09-18 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125302/ --- Review request for Baloo and Pinak Ahuja. Repository: baloo Description