Re: Review Request 125257: i18nize Indexer State in balooctl and baloomonitor plugin

2015-09-18 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125257/ --- (Updated Sept. 19, 2015, 5:28 a.m.) Status -- This change has been m

Re: Review Request 125257: i18nize Indexer State in balooctl and baloomonitor plugin

2015-09-18 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125257/#review85644 --- Ship it! Ship It! - Albert Astals Cid On set. 16, 2015, 11

Re: Review Request 125257: i18nize Indexer State in balooctl and baloomonitor plugin

2015-09-18 Thread Pinak Ahuja
> On Sept. 17, 2015, 9:25 p.m., Albert Astals Cid wrote: > > Would these also need i18n? > > > > if (running) { > > out << "Baloo File Indexer is running\n"; > > out << "Indexer state: " << > > stateString(schedulerinterface.state()) << endl; > >

Re: Review Request 125257: i18nize Indexer State in balooctl and baloomonitor plugin

2015-09-17 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125257/#review85591 --- Would these also need i18n? if (running) {

Re: Review Request 125257: i18nize Indexer State in balooctl and baloomonitor plugin

2015-09-16 Thread Pinak Ahuja
> On Sept. 16, 2015, 7:32 p.m., Albert Astals Cid wrote: > > Are we compiling this file twice? Yes, we compile indexerstate.h twice, first in balooctl and also in baloomonitorplugin. Actually it is compiled in baloo_file as well but it just uses the enum and not the strings. - Pinak --

Re: Review Request 125257: i18nize Indexer State in balooctl and baloomonitor plugin

2015-09-16 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125257/#review85510 --- Are we compiling this file twice? - Albert Astals Cid On se

Review Request 125257: i18nize Indexer State in balooctl and baloomonitor plugin

2015-09-16 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125257/ --- Review request for Baloo, Localization and Translation (l10n) and Vishesh H