Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-10 Thread Pinak Ahuja
> On Sept. 10, 2015, 6:38 a.m., David Faure wrote: > > src/file/mainadaptor.cpp, line 45 > > > > > > This could be a real method call instead, so that it doesn't break when > > someone renames/removes updateConfi

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-10 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125125/ --- (Updated Sept. 10, 2015, 7:36 a.m.) Status -- This change has been m

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-10 Thread David Faure
> On Sept. 10, 2015, 6:38 a.m., David Faure wrote: > > src/file/mainadaptor.cpp, line 45 > > > > > > This could be a real method call instead, so that it doesn't break when > > someone renames/removes updateConfi

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-09 Thread Pinak Ahuja
> On Sept. 10, 2015, 6:38 a.m., David Faure wrote: > > src/file/mainadaptor.cpp, line 45 > > > > > > This could be a real method call instead, so that it doesn't break when > > someone renames/removes updateConfi

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125125/#review85084 --- src/file/mainadaptor.cpp (line 45)

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-09 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125125/ --- (Updated Sept. 10, 2015, 5:28 a.m.) Status -- This change has been m

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-09 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125125/#review85076 --- Ship it! - Vishesh Handa On Sept. 9, 2015, 9:38 p.m., Pinak

Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-09 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125125/ --- Review request for Baloo, David Faure and Vishesh Handa. Repository: balo