Re: Review Request 124919: Re-organize D-Bus interfaces

> On Aug. 31, 2015, 8:45 a.m., Hrvoje Senjan wrote: > > src/dbus/CMakeLists.txt, line 26 > > > > > > This looks like a SiC change to me, no? e.g. plasma-desktop won't build > > with this commit > > Harald Sitter

Re: Review Request 124919: Re-organize D-Bus interfaces

> On Aug. 31, 2015, 8:45 a.m., Hrvoje Senjan wrote: > > src/dbus/CMakeLists.txt, line 26 > > > > > > This looks like a SiC change to me, no? e.g. plasma-desktop won't build > > with this commit > > Harald Sitter

Re: Review Request 124919: Re-organize D-Bus interfaces

> On Aug. 31, 2015, 8:45 a.m., Hrvoje Senjan wrote: > > src/dbus/CMakeLists.txt, line 26 > > > > > > This looks like a SiC change to me, no? e.g. plasma-desktop won't build > > with this commit > > Harald Sitter

Re: Review Request 124919: Re-organize D-Bus interfaces

> On Aug. 31, 2015, 8:45 a.m., Hrvoje Senjan wrote: > > src/dbus/CMakeLists.txt, line 26 > > > > > > This looks like a SiC change to me, no? e.g. plasma-desktop won't build > > with this commit > > Harald Sitter

Re: Review Request 124919: Re-organize D-Bus interfaces

> On Aug. 31, 2015, 10:45 a.m., Hrvoje Senjan wrote: > > src/dbus/CMakeLists.txt, line 26 > > > > > > This looks like a SiC change to me, no? e.g. plasma-desktop won't build > > with this commit > > Harald Sitte

Re: Review Request 124919: Re-organize D-Bus interfaces

> On Aug. 31, 2015, 8:45 a.m., Hrvoje Senjan wrote: > > src/dbus/CMakeLists.txt, line 26 > > > > > > This looks like a SiC change to me, no? e.g. plasma-desktop won't build > > with this commit > > Harald Sitter

Re: Review Request 124919: Re-organize D-Bus interfaces

> On Aug. 31, 2015, 8:45 a.m., Hrvoje Senjan wrote: > > src/dbus/CMakeLists.txt, line 26 > > > > > > This looks like a SiC change to me, no? e.g. plasma-desktop won't build > > with this commit > > Harald Sitter

Re: Review Request 124919: Re-organize D-Bus interfaces

> On Aug. 31, 2015, 8:45 a.m., Hrvoje Senjan wrote: > > src/dbus/CMakeLists.txt, line 26 > > > > > > This looks like a SiC change to me, no? e.g. plasma-desktop won't build > > with this commit Yeah unfortunatel

Re: Review Request 124919: Re-organize D-Bus interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124919/#review84622 --- src/dbus/CMakeLists.txt (line 26)

Re: Review Request 124919: Re-organize D-Bus interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124919/#review84582 --- Ship it! - Vishesh Handa On Aug. 25, 2015, 5:52 p.m., Pinak

Re: Review Request 124919: Re-organize D-Bus interfaces

> On Aug. 25, 2015, 4:54 p.m., Vishesh Handa wrote: > > src/file/filecontentindexer.cpp, line 134 > > > > > > This might not be thread safe. > > > > It calls batchTimings which accesses `m_batchTimeBuffe

Re: Review Request 124919: Re-organize D-Bus interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124919/ --- (Updated Aug. 25, 2015, 5:52 p.m.) Review request for Baloo and Vishesh H

Re: Review Request 124919: Re-organize D-Bus interfaces

> On Aug. 25, 2015, 4:54 p.m., Vishesh Handa wrote: > > Looks good. The only minor thing I realized is that I'm not sure how QtDbus > > behaves with interfaces which appear and disappear (contentIndexer). ContentIndexer doesn't appear and disappear now, it's a long lived class, with this patch

Re: Review Request 124919: Re-organize D-Bus interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124919/#review84352 --- Looks good. The only minor thing I realized is that I'm not su

Review Request 124919: Re-organize D-Bus interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124919/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti