Re: Review Request 124162: Only export urls when monitor is running

> On June 30, 2015, 6:39 p.m., Stefan Brüns wrote: > > src/file/extractor/org.kde.balooExtractor.xml, line 3 > > > > > > Sorry, the generated header does not like to be included from inside a > > namespace. > >

Re: Review Request 124162: Only export urls when monitor is running

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124162/#review81913 --- src/file/extractor/org.kde.balooExtractor.xml (line 3)

Re: Review Request 124162: Only export urls when monitor is running

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124162/#review81911 --- src/file/extractor/org.kde.balooExtractor.xml (line 3)

Re: Review Request 124162: Only export urls when monitor is running

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124162/ --- (Updated June 30, 2015, 4:45 p.m.) Status -- This change has been ma

Re: Review Request 124162: Only export urls when monitor is running

> On June 30, 2015, 3:14 p.m., Stefan Brüns wrote: > > src/file/extractor/org.kde.balooExtractor.xml, line 3 > > > > > > Any reason to name the service org.kde.baloo.extractor, but the > > interface org.kde.balooE

Re: Review Request 124162: Only export urls when monitor is running

> On June 30, 2015, 3:14 p.m., Stefan Brüns wrote: > > src/file/extractor/org.kde.balooExtractor.xml, line 3 > > > > > > Any reason to name the service org.kde.baloo.extractor, but the > > interface org.kde.balooE

Re: Review Request 124162: Only export urls when monitor is running

> On June 30, 2015, 3:14 p.m., Stefan Brüns wrote: > > src/file/extractor/org.kde.balooExtractor.xml, line 3 > > > > > > Any reason to name the service org.kde.baloo.extractor, but the > > interface org.kde.balooE

Re: Review Request 124162: Only export urls when monitor is running

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124162/#review81905 --- src/file/extractor/org.kde.balooExtractor.xml (line 3)

Re: Review Request 124162: Only export urls when monitor is running

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124162/ --- (Updated June 30, 2015, 12:11 p.m.) Review request for Baloo and Vishesh

Re: Review Request 124162: Only export urls when monitor is running

> On June 29, 2015, 5:04 a.m., Vishesh Handa wrote: > > src/file/extractor/app.h, line 48 > > > > > > Are you sure this works? > > > > The syntax seems a bit strange. I thought it should be "... READ > >

Re: Review Request 124162: Only export urls when monitor is running

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124162/#review81840 --- src/file/extractor/app.h (line 48)

Re: Review Request 124162: Only export urls when monitor is running

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124162/ --- (Updated June 27, 2015, 12:32 p.m.) Review request for Baloo and Vishesh

Re: Review Request 124162: Only export urls when monitor is running

> On June 24, 2015, 10:54 p.m., Stefan Brüns wrote: > > Some comments about the DBus interface you are exporting: > > I think you should make the current file name a property. Signal changes > > through the standard PropertiesChanged DBus signal. This way you can also > > add more properties la

Re: Review Request 124162: Only export urls when monitor is running

> On June 24, 2015, 10:54 p.m., Stefan Brüns wrote: > > Some comments about the DBus interface you are exporting: > > I think you should make the current file name a property. Signal changes > > through the standard PropertiesChanged DBus signal. This way you can also > > add more properties la

Re: Review Request 124162: Only export urls when monitor is running

> On June 24, 2015, 10:54 p.m., Stefan Brüns wrote: > > Some comments about the DBus interface you are exporting: > > I think you should make the current file name a property. Signal changes > > through the standard PropertiesChanged DBus signal. This way you can also > > add more properties la

Re: Review Request 124162: Only export urls when monitor is running

> On June 24, 2015, 10:54 p.m., Stefan Brüns wrote: > > Some comments about the DBus interface you are exporting: > > I think you should make the current file name a property. Signal changes > > through the standard PropertiesChanged DBus signal. This way you can also > > add more properties la

Re: Review Request 124162: Only export urls when monitor is running

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124162/#review81736 --- Some comments about the DBus interface you are exporting: I th

Review Request 124162: Only export urls when monitor is running

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124162/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti

Re: Review Request 124162: Only export urls when monitor is running

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124162/ --- (Updated June 24, 2015, 11:52 a.m.) Review request for Baloo and Vishesh