Re: Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-21 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124082/ --- (Updated June 21, 2015, 4:08 p.m.) Status -- This change has been ma

Re: Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-20 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124082/#review81600 --- Ship it! - Vishesh Handa On June 20, 2015, 6:53 a.m., Pinak

Re: Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-19 Thread Pinak Ahuja
> On June 18, 2015, 6:39 p.m., Vishesh Handa wrote: > > src/file/timeestimator.h, line 30 > > > > > > Are you sure you're using this class? Right now only in the test but when the new architecture is implemented

Re: Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-19 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124082/ --- (Updated June 20, 2015, 6:53 a.m.) Review request for Baloo and Vishesh H

Re: Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-18 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124082/#review81562 --- This is starting to look quite good. src/file/extractor/main

Re: Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-18 Thread Pinak Ahuja
> On June 18, 2015, 1:03 a.m., Vishesh Handa wrote: > > I'm not quite comfortable with this code. It makes the FileContentIndexer > > class way messier, but I haven't thought enough on how to improve it. Now filecontentindexer just returns average time per batch which is required all the time

Re: Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-18 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124082/ --- (Updated June 18, 2015, 12:46 p.m.) Review request for Baloo and Vishesh

Re: Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-17 Thread Pinak Ahuja
> On June 18, 2015, 1:03 a.m., Vishesh Handa wrote: > > src/file/extractor/main.cpp, line 45 > > > > > > I would prefer if you just set an BALOO_DB_PATH environment variable, > > and used that all over the code i

Re: Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-17 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124082/#review81543 --- I'm not quite comfortable with this code. It makes the FileCon

Re: Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-16 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124082/ --- (Updated June 16, 2015, 11:40 a.m.) Review request for Baloo and Vishesh

Re: Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-12 Thread Vishesh Handa
> On June 12, 2015, 3:45 p.m., Vishesh Handa wrote: > > I'm fine with this simple approach as a starting point, but I'm not sure if > > FileContentIndexer is the correct place. I am not quite sure how you're > > planning to hook this up with the monitor. > > > > Also has this been tested? > >

Re: Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-12 Thread Pinak Ahuja
> On June 12, 2015, 3:45 p.m., Vishesh Handa wrote: > > I'm fine with this simple approach as a starting point, but I'm not sure if > > FileContentIndexer is the correct place. I am not quite sure how you're > > planning to hook this up with the monitor. > > > > Also has this been tested? * T

Re: Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-12 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124082/#review81412 --- I'm fine with this simple approach as a starting point, but I'

Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-12 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124082/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti