Re: Review Request 123964: Re-introduce batch committing in baloo_file_extractor

2015-06-02 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123964/ --- (Updated June 2, 2015, 12:05 p.m.) Status -- This change has been ma

Re: Review Request 123964: Re-introduce batch committing in baloo_file_extractor

2015-06-02 Thread Pinak Ahuja
> On June 2, 2015, 11:25 a.m., Vishesh Handa wrote: > > src/file/extractor/iohandler.h, line 49 > > > > > > You do not really need this variable. You could just decrease the > > `m_batchSize` each time. Yeah, th

Re: Review Request 123964: Re-introduce batch committing in baloo_file_extractor

2015-06-02 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123964/#review81072 --- Ship it! Good work. Next time. This should be 3 different pa

Re: Review Request 123964: Re-introduce batch committing in baloo_file_extractor

2015-05-31 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123964/ --- (Updated June 1, 2015, 4:33 a.m.) Review request for Baloo and Vishesh Ha

Re: Review Request 123964: Re-introduce batch committing in baloo_file_extractor

2015-05-31 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123964/ --- (Updated May 31, 2015, 4:40 p.m.) Review request for Baloo and Vishesh Ha

Review Request 123964: Re-introduce batch committing in baloo_file_extractor

2015-05-31 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123964/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti