Re: Review Request 120466: Completed unit test for BasicIndexingJob

2014-10-04 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120466/ --- (Updated Oct. 4, 2014, 7:53 a.m.) Status -- This change has been mar

Re: Review Request 120466: Completed unit test for BasicIndexingJob

2014-10-03 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120466/#review67881 --- Ship it! src/file/autotest/basicindexingjobtest.cpp

Re: Review Request 120466: Completed unit test for BasicIndexingJob

2014-10-03 Thread Pinak Ahuja
> On Oct. 3, 2014, 3:22 p.m., Vishesh Handa wrote: > > src/file/autotest/basicindexingjobtest.cpp, line 111 > > > > > > This part of the test wouldn't actually be checking anything since this > > temporary file

Re: Review Request 120466: Completed unit test for BasicIndexingJob

2014-10-03 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120466/ --- (Updated Oct. 3, 2014, 5:16 p.m.) Review request for Baloo and Vishesh Ha

Re: Review Request 120466: Completed unit test for BasicIndexingJob

2014-10-03 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120466/#review67862 --- Nice work. You're almost there. src/file/autotest/basicindex

Review Request 120466: Completed unit test for BasicIndexingJob

2014-10-02 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120466/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti