Re: Review Request 119511: Removed KDialog from kcommentwidget

2014-07-29 Thread Felix Eisele
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119511/ --- (Updated July 29, 2014, 12:26 p.m.) Status -- This change has been m

Re: Review Request 119511: Removed KDialog from kcommentwidget

2014-07-29 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119511/#review63395 --- Ship it! Ship It! - Vishesh Handa On July 28, 2014, 6:17 p

Re: Review Request 119511: Removed KDialog from kcommentwidget

2014-07-28 Thread Felix Eisele
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119511/ --- (Updated Juli 28, 2014, 8:17 nachm.) Review request for Baloo and Vishesh

Re: Review Request 119511: Removed KDialog from kcommentwidget

2014-07-28 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119511/#review63341 --- Looks good! :D src/keditcommentdialog.h

Re: Review Request 119511: Removed KDialog from kcommentwidget

2014-07-28 Thread Felix Eisele
> On Juli 28, 2014, 12:33 nachm., Kai Uwe Broulik wrote: > > No opinion on the patch but a few coding style issues, see below: Thank you for your reply. I'm very new in programming qt/kde. I saw we are very close neighbours. I live in waiblingen. > On Juli 28, 2014, 12:33 nachm., Kai Uwe Broul

Re: Review Request 119511: Removed KDialog from kcommentwidget

2014-07-28 Thread Felix Eisele
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119511/ --- (Updated Juli 28, 2014, 2:27 nachm.) Review request for Baloo and Vishesh

Re: Review Request 119511: Removed KDialog from kcommentwidget

2014-07-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119511/#review63314 --- No opinion on the patch but a few coding style issues, see bel

Review Request 119511: Removed KDialog from kcommentwidget

2014-07-28 Thread Felix Eisele
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119511/ --- Review request for Baloo and Vishesh Handa. Repository: baloo-widgets D